All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: David Eger <eger-dated-1086437670.7c6138@theboonies.us>,
	David Eger <eger-sender-da68b9@theboonies.us>,
	linux-fbdev-devel@lists.sourceforge.net
Subject: Re: fbset noaccel
Date: Mon, 31 May 2004 09:08:12 +0800	[thread overview]
Message-ID: <200405310908.12783.adaplas@hotpop.com> (raw)
In-Reply-To: <1085832863.40b87e9fde073@mail.theboonies.us>

On Saturday 29 May 2004 20:14, David Eger wrote:
> [ reads through fbset code ]
>
> So it looks like fbset turns off acceleration by setting up the accel flag
> in var (that FB_ACCELF_TEXT oddity).
>
> While it makes sense that changing acceleration is a mode-switch item
> (quiescing video engine and such), it seems more like it should be an ioctl
> (or sysfs!) thing now...  Changing certain bits of var and hoping that
> set_var() will guess in the correct way seems generally b0rken...
>
> comments?
>

It's not as bad as it seems.  As long as an accelerated driver does not ignore 
this flag and properly flushes->syncs->disables the accel engine on a 
set_var, it should work.  Plus, a lot of apps clear/depend on this flag 
(XFree86-fbdev, fbset, DirectFB, etc).

I agree though that turning off/syncing/flushing the accel engine deserves 
it's own ioctl/method so as to completely separate it from mode switching 
which is a different process in itself.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click

  reply	other threads:[~2004-05-31  1:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-28 11:58 [ PATCH-LINK ] fb accel capabilities - take 2 Thomas Winischhofer
2004-05-29  8:36 ` David Eger
2004-05-29 12:14   ` fbset noaccel David Eger
2004-05-31  1:08     ` Antonino A. Daplas [this message]
2004-05-30 11:44   ` [ PATCH-LINK ] fb accel capabilities - take 2 Thomas Winischhofer
2004-05-31  1:08     ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405310908.12783.adaplas@hotpop.com \
    --to=adaplas@hotpop.com \
    --cc=adaplas@pol.net \
    --cc=eger-dated-1086437670.7c6138@theboonies.us \
    --cc=eger-sender-da68b9@theboonies.us \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.