From: William Lee Irwin III <wli@holomorphy.com>
To: Dominik Karall <dominik.karall@gmx.net>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.7-rc2-mm1
Date: Tue, 1 Jun 2004 04:24:18 -0700 [thread overview]
Message-ID: <20040601112418.GM2093@holomorphy.com> (raw)
In-Reply-To: <200406011248.16303.dominik.karall@gmx.net>
On Tue, Jun 01, 2004 at 12:48:16PM +0200, Dominik Karall wrote:
> CC drivers/scsi/sr_ioctl.o
> drivers/scsi/sr_ioctl.c: In Funktion >>sr_read_cd<<:
> drivers/scsi/sr_ioctl.c:435: error: conflicting types for `cgc'
> drivers/scsi/sr_ioctl.c:434: error: previous declaration of `cgc'
> drivers/scsi/sr_ioctl.c:469: Warnung: Verarbeiten des Argumentes 2 von
> >>sr_do_ioctl<< von inkompatiblem Zeigertyp
> drivers/scsi/sr_ioctl.c: In Funktion >>sr_read_sector<<:
> drivers/scsi/sr_ioctl.c:479: error: conflicting types for `cgc'
> drivers/scsi/sr_ioctl.c:478: error: previous declaration of `cgc'
> drivers/scsi/sr_ioctl.c:512: Warnung: Verarbeiten des Argumentes 2 von
> >>sr_do_ioctl<< von inkompatiblem Zeigertyp
> make[3]: *** [drivers/scsi/sr_ioctl.o] Fehler 1
> make[2]: *** [drivers/scsi] Fehler 2
> make[1]: *** [drivers] Fehler 2
There's a plot down there I don't completely understand. Until those
who know what's going on materialize:
Index: linux-2.6.7-rc2-mm1/drivers/scsi/sr_ioctl.c
===================================================================
--- linux-2.6.7-rc2-mm1.orig/drivers/scsi/sr_ioctl.c 2004-06-01 03:25:53.000000000 -0700
+++ linux-2.6.7-rc2-mm1/drivers/scsi/sr_ioctl.c 2004-06-01 04:12:12.000000000 -0700
@@ -432,7 +432,6 @@
static int sr_read_cd(Scsi_CD *cd, unsigned char *dest, int lba, int format, int blksize)
{
struct packet_command cgc;
- struct cdrom_generic_command cgc;
#ifdef DEBUG
printk("%s: sr_read_cd lba=%d format=%d blksize=%d\n",
@@ -440,7 +439,6 @@
#endif
memset(&cgc, 0, sizeof(struct packet_command));
- memset(&cgc, 0, sizeof(struct cdrom_generic_command));
cgc.cmd[0] = GPCMD_READ_CD; /* READ_CD */
cgc.cmd[1] = ((format & 7) << 2);
cgc.cmd[2] = (unsigned char) (lba >> 24) & 0xff;
@@ -476,7 +474,6 @@
static int sr_read_sector(Scsi_CD *cd, int lba, int blksize, unsigned char *dest)
{
struct packet_command cgc;
- struct cdrom_generic_command cgc;
int rc;
/* we try the READ CD command first... */
@@ -498,7 +495,6 @@
#endif
memset(&cgc, 0, sizeof(struct packet_command));
- memset(&cgc, 0, sizeof(struct cdrom_generic_command));
cgc.cmd[0] = GPCMD_READ_10;
cgc.cmd[2] = (unsigned char) (lba >> 24) & 0xff;
cgc.cmd[3] = (unsigned char) (lba >> 16) & 0xff;
next prev parent reply other threads:[~2004-06-01 11:24 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-01 9:15 2.6.7-rc2-mm1 Andrew Morton
2004-06-01 9:59 ` 2.6.7-rc2-mm1 Alexander Gran
2004-06-01 11:28 ` 2.6.7-rc2-mm1 AKIYAMA Nobuyuki
2004-06-01 11:39 ` 2.6.7-rc2-mm1 Alexander Gran
2004-06-01 16:07 ` 2.6.7-rc2-mm1 Ari Pollak
2004-06-01 16:22 ` 2.6.7-rc2-mm1 Ari Pollak
2004-06-01 10:00 ` 2.6.7-rc2-mm1 Gabriel Ebner
2004-06-01 11:05 ` 2.6.7-rc2-mm1 Andrey Panin
2004-06-01 13:58 ` 2.6.7-rc2-mm1 Gabriel Ebner
2004-06-01 14:05 ` 2.6.7-rc2-mm1 Jan Killius
2004-06-01 10:29 ` 2.6.7-rc2-mm1 Christoph Hellwig
2004-06-01 13:43 ` 2.6.7-rc2-mm1 Mikael Pettersson
2004-06-01 13:57 ` 2.6.7-rc2-mm1 Christoph Hellwig
2004-06-01 14:14 ` 2.6.7-rc2-mm1 Mikael Pettersson
2004-06-01 10:48 ` 2.6.7-rc2-mm1 Dominik Karall
2004-06-01 11:24 ` William Lee Irwin III [this message]
2004-06-01 11:37 ` 2.6.7-rc2-mm1 William Lee Irwin III
2004-06-02 10:18 ` 2.6.7-rc2-mm1 Paul Jackson
2004-06-02 10:23 ` 2.6.7-rc2-mm1 Andrew Morton
2004-06-05 11:07 ` 2.6.7-rc2-mm1 Matthias Urlichs
2004-06-06 8:02 ` 2.6.7-rc2-mm1 Paul Jackson
2004-06-01 11:26 ` 2.6.7-rc2-mm1 William Lee Irwin III
2004-06-01 11:36 ` 2.6.7-rc2-mm1 Keith Owens
2004-06-01 11:26 ` 2.6.7-rc2-mm1 Andy Lutomirski
2004-06-01 11:29 ` 2.6.7-rc2-mm1 William Lee Irwin III
2004-06-01 16:24 ` 2.6.7-rc2-mm1 Mikael Pettersson
2004-06-01 11:51 ` 2.6.7-rc2-mm1 Alexander Gran
2004-06-01 12:19 ` 2.6.7-rc2-mm1 Eric BEGOT
2004-06-01 16:19 ` 2.6.7-rc2-mm1 Adrian Bunk
2004-06-01 21:18 ` 2.6.7-rc2-mm1 Chris Wedgwood
2004-06-01 21:36 ` 2.6.7-rc2-mm1 Andrew Morton
2004-06-01 21:36 ` 2.6.7-rc2-mm1 David S. Miller
2004-06-01 22:21 ` 2.6.7-rc2-mm1 Alexander Gran
2004-06-01 21:45 ` 2.6.7-rc2-mm1 Alex Romosan
2004-06-01 14:55 ` 2.6.7-rc2-mm1: gcc 2.95 uaccess.h warnings Adrian Bunk
2004-06-01 15:03 ` Linus Torvalds
2004-06-01 16:10 ` Adrian Bunk
2004-06-01 16:07 ` 2.6.7-rc2-mm1 Norberto Bensa
2004-06-01 16:07 ` 2.6.7-rc2-mm1: e1000_ethtool.c compile error Adrian Bunk
2004-06-01 19:09 ` 2.6.7-rc2-mm1 Dominik Karall
2004-06-01 19:47 ` 2.6.7-rc2-mm1 Luiz Fernando N. Capitulino
2004-06-01 21:06 ` 2.6.7-rc2-mm1 Dominik Karall
2004-06-01 19:35 ` 2.6.7-rc2-mm1: compile error in kernel/exit.c Peter Lundkvist
2004-06-01 21:24 ` Mikael Pettersson
2004-06-01 23:12 ` 2.6.7-rc2-mm1 (compile stats) John Cherry
2004-06-02 0:39 ` [patch] 2.6.7-rc2-mm1: let SERIAL_8250_ACPI depend on ACPI_PCI Adrian Bunk
2004-06-02 11:27 ` [ACPI] " Matthew Wilcox
[not found] ` <20040602003938.GJ25681-cg1h10c7RbKzQB+pC5nmwQ@public.gmane.org>
2004-06-02 16:51 ` Bjorn Helgaas
2004-06-02 16:51 ` Bjorn Helgaas
2004-06-02 1:24 ` [1/2] use const in time.h unit conversion functions William Lee Irwin III
2004-06-02 1:26 ` [2/2] fix io_getevents() timer expiry setting William Lee Irwin III
2004-06-02 18:43 ` [1/2] use const in time.h unit conversion functions Matt Mackall
2004-06-02 18:52 ` William Lee Irwin III
2004-06-03 8:17 ` Denis Vlasenko
2004-06-02 9:21 ` 2.6.7-rc2-mm1 - bk-netdev.patch e1000_ethtool.c doesn't build Paul Jackson
2004-06-02 9:41 ` Paul Jackson
2004-06-02 13:26 ` 2.6.7-rc2-mm1 William Lee Irwin III
2004-06-03 23:38 ` 2.6.7-rc2-mm1 Greg KH
2004-06-04 0:07 ` 2.6.7-rc2-mm1 William Lee Irwin III
2004-06-04 5:18 ` 2.6.7-rc2-mm1 Vojtech Pavlik
2004-06-03 0:51 ` 2.6.7-rc2-mm1 Joshua Kwan
2004-06-03 13:24 ` 2.6.7-rc2-mm1 Mikael Pettersson
[not found] <22dBi-3Hb-27@gated-at.bofh.it>
[not found] ` <22exj-4ty-15@gated-at.bofh.it>
[not found] ` <22fjG-56P-11@gated-at.bofh.it>
[not found] ` <22i80-7v8-41@gated-at.bofh.it>
2004-06-01 15:19 ` 2.6.7-rc2-mm1 Andi Kleen
2004-06-01 15:58 ` 2.6.7-rc2-mm1 Gabriel Ebner
-- strict thread matches above, loose matches on Subject: below --
2004-06-01 22:49 2.6.7-rc2-mm1 Sid Boyce
2004-06-02 13:39 2.6.7-rc2-mm1 Sid Boyce
2004-06-03 4:28 ` 2.6.7-rc2-mm1 Andrew Morton
2004-06-03 11:30 ` 2.6.7-rc2-mm1 Sid Boyce
2004-06-03 13:18 ` 2.6.7-rc2-mm1 Sid Boyce
2004-06-03 22:04 ` 2.6.7-rc2-mm1 Sid Boyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040601112418.GM2093@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=dominik.karall@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.