From: Jens Axboe <axboe@suse.de>
To: Christophe Saout <christophe@saout.de>
Cc: Alasdair G Kergon <agk@redhat.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 5/5: Device-mapper: dm-zero
Date: Wed, 2 Jun 2004 18:09:05 +0200 [thread overview]
Message-ID: <20040602160905.GX28915@suse.de> (raw)
In-Reply-To: <1086192141.4659.1.camel@leto.cs.pocnet.net>
On Wed, Jun 02 2004, Christophe Saout wrote:
> Am Mi, den 02.06.2004 um 16:46 Uhr +0100 schrieb Alasdair G Kergon:
>
> > + bio_for_each_segment(bv, bio, i) {
> > + char *data = bvec_kmap_irq(bv, &flags);
> > + memset(data, 0, bv->bv_len);
>
> I just noticed, there's a
>
> flush_dcache_page(bv->bv_page);
>
> missing here.
>
> > + bvec_kunmap_irq(bv, &flags);
and even worse, passing bad argument to bvec_kunmap_irq().
--
Jens Axboe
next prev parent reply other threads:[~2004-06-02 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 15:46 [PATCH] 5/5: Device-mapper: dm-zero Alasdair G Kergon
2004-06-02 16:02 ` Christophe Saout
2004-06-02 16:09 ` Jens Axboe [this message]
2004-06-02 16:17 ` Christophe Saout
2004-06-02 16:26 ` Christophe Saout
2004-06-02 19:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040602160905.GX28915@suse.de \
--to=axboe@suse.de \
--cc=agk@redhat.com \
--cc=akpm@osdl.org \
--cc=christophe@saout.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.