Re: udev - flag for preserving the ownership

[Olaf Hering <olh@suse.de>]

 On Wed, Jun 02, Harald Hoyer wrote:

> Harald Hoyer wrote:
> >How about a config flag, which means that udev preserves the ownership 
> >of an already existing device node (with the correct major, minor numbers)?
> >
> >Btw, we only check if the file we want to create is block or char, not 
> >e.g. that we want block and it is char.
> >
> >if (((stats.st_mode & S_IFMT) = S_IFBLK || (stats.st_mode & S_IFMT) = 
> >S_IFCHR) && (stats.st_rdev = makedev(major, minor)))
> >
> >should look like:
> >
> >if (((stats.st_mode & S_IFMT) = mode) && (stats.st_rdev = 
> >makedev(major, minor)))
> 
> how about this (see attachement)?

I havent looked at the larger context, but I believe this changes
behaviour of udev. Currently udevstart can fix up your system for sure,
but with this change, a bogus file will not be removed if it happens to
have the same permissions.
Or will stats.st_rdev = makedev(major, minor) take care of that?

> --- udev-025/udev-add.c.keep	2004-04-21 23:39:10.000000000 +0200
> +++ udev-025/udev-add.c	2004-06-02 12:08:16.728855024 +0200
> @@ -114,10 +114,10 @@
>  		goto create;
>  
>  	/* preserve node with already correct numbers, to not change the inode number */
> -	if (((stats.st_mode & S_IFMT) = S_IFBLK || (stats.st_mode & S_IFMT) = S_IFCHR) &&
> +	if (((stats.st_mode & S_IFMT) = (mode & S_IFMT)) &&
>  	    (stats.st_rdev = makedev(major, minor))) {
>  		dbg("preserve file '%s', cause it has correct dev_t", file);
> -		goto perms;
> +		goto exit;
>  	}
>  
>  	if (unlink(file) != 0)




-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, n√úRNBERG


-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel