All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Elie <phil.el@wanadoo.fr>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Jens Schmalzing <j.s@lmu.de>,
	linux-kernel@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH] OProfile driver in 2.6
Date: Wed, 2 Jun 2004 18:37:20 +0000	[thread overview]
Message-ID: <20040602183720.GC385@zaniah> (raw)
In-Reply-To: <20040602155056.GG15195@smtp.west.cox.net>

On Wed, 02 Jun 2004 at 08:50 +0000, Tom Rini wrote:

> On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
> 
> > Hi,
> > 
> > I noticed that the driver for the OProfile profiling system, which
> > existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
> > even though the driver still exists.  Is there a reason for this?  The
> > attached patch re-enables the driver.
> 
> Because it has never been picked up, aside from when Ben took it into
> his tree (assuming this is the patch Anton wrote a while back, and not
> a re-write Ben did).  BTW, this is missing a hunk I think, unless the
> arch/ppc/kernel/time.c changes have already made it in.

Right there is a missing call to profile_hook(regs); in ppc_do_profile()

regards,
Phil

  reply	other threads:[~2004-06-02 16:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-02  9:19 [PATCH] OProfile driver in 2.6 Jens Schmalzing
2004-06-02 15:50 ` Tom Rini
2004-06-02 18:37   ` Philippe Elie [this message]
2004-06-02 17:51     ` Greg Weeks
2004-06-02 20:12   ` Jens Schmalzing
2004-06-02 17:03 ` Philippe Elie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040602183720.GC385@zaniah \
    --to=phil.el@wanadoo.fr \
    --cc=benh@kernel.crashing.org \
    --cc=j.s@lmu.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.