All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: hch@infradead.org, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: Export swapper_space
Date: Thu, 3 Jun 2004 10:08:26 -0700	[thread overview]
Message-ID: <20040603100826.2fd235c8.akpm@osdl.org> (raw)
In-Reply-To: <20040603170137.E8244@flint.arm.linux.org.uk>

Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>
> > Please not.  This seems to be some cache-flushing magic on the stranger
>  > architectures again :)  Can you check how they're using it in the end
>  > and hopefully fix it by uninlining something?
> 
>  extern struct address_space swapper_space;
>  static inline struct address_space *page_mapping(struct page *page)
>  {
>          struct address_space *mapping = NULL;
>   
>          if (unlikely(PageSwapCache(page)))
>                  mapping = &swapper_space;
>          else if (likely(!PageAnon(page)))
>                  mapping = page->mapping;
>          return mapping;
>  }

Christoph means "can arm uninline flush_dcache_page()"?

It looks like that would be the best approach - it's quite a large function.

  reply	other threads:[~2004-06-03 17:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-03 15:19 Export swapper_space Russell King
2004-06-03 15:37 ` Christoph Hellwig
2004-06-03 16:01   ` Russell King
2004-06-03 17:08     ` Andrew Morton [this message]
2004-06-03 17:21       ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040603100826.2fd235c8.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.