From: "David S. Miller" <davem@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: olh@suse.de, linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing
Date: Sat, 5 Jun 2004 14:36:49 -0700 [thread overview]
Message-ID: <20040605143649.3fd6c22b.davem@redhat.com> (raw)
In-Reply-To: <jer7st7lam.fsf@sykes.suse.de>
On Sat, 05 Jun 2004 23:21:53 +0200
Andreas Schwab <schwab@suse.de> wrote:
> "David S. Miller" <davem@redhat.com> writes:
>
> > This means also that Olaf's patch is broken, when CONFIG_COMPAT is not
> > set, MSG_CMSG_COMPAT is zero, thus ~MSG_CMSG_COMPAT is the unexpected
> > value all 1's thus breaking the tests for unexpected flags completely.
>
> ??? Where do you get ~MSG_CMSG_COMPAT from?
Olaf's patch, it said:
- if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC))
+ if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC|MSG_CMSG_COMPAT))
next prev parent reply other threads:[~2004-06-05 21:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-05 20:43 [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing Olaf Hering
2004-06-05 21:01 ` David S. Miller
2004-06-05 21:05 ` David S. Miller
2004-06-05 21:21 ` Andreas Schwab
2004-06-05 21:36 ` David S. Miller [this message]
2004-06-05 21:47 ` Andreas Schwab
2004-06-05 21:53 ` David S. Miller
2004-06-05 22:05 ` Andreas Schwab
2004-06-05 22:29 ` David S. Miller
2004-06-05 22:37 ` Olaf Hering
2004-06-05 22:55 ` David S. Miller
2004-06-05 21:17 ` Olaf Hering
2004-06-05 21:37 ` David S. Miller
2004-06-05 21:14 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040605143649.3fd6c22b.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=olh@suse.de \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.