From: William Lee Irwin III <wli@holomorphy.com>
To: Con Kolivas <kernel@kolivas.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Zwane Mwaikambo <zwane@linuxpower.ca>
Subject: Re: [PATCH] Staircase Scheduler v6.3 for 2.6.7-rc2
Date: Mon, 7 Jun 2004 07:04:45 -0700 [thread overview]
Message-ID: <20040607140445.GA21007@holomorphy.com> (raw)
In-Reply-To: <20040607135738.GZ21007@holomorphy.com>
On Mon, Jun 07, 2004 at 06:57:38AM -0700, William Lee Irwin III wrote:
> JIFFIES_TO_NS() is unused.
array->nr_active only ever modified, never examined.
Index: kolivas-2.6.7-rc2/kernel/sched.c
===================================================================
--- kolivas-2.6.7-rc2.orig/kernel/sched.c 2004-06-07 06:53:26.779390000 -0700
+++ kolivas-2.6.7-rc2/kernel/sched.c 2004-06-07 07:03:00.910109000 -0700
@@ -92,7 +92,6 @@
typedef struct runqueue runqueue_t;
struct prio_array {
- unsigned int nr_active;
unsigned long bitmap[BITMAP_SIZE];
struct list_head queue[MAX_PRIO + 1];
};
@@ -204,7 +203,6 @@
static void dequeue_task(struct task_struct *p, runqueue_t *rq)
{
prio_array_t* array = &rq->array;
- array->nr_active--;
list_del(&p->run_list);
if (list_empty(array->queue + p->prio))
__clear_bit(p->prio, array->bitmap);
@@ -215,7 +213,6 @@
prio_array_t* array = &rq->array;
list_add_tail(&p->run_list, array->queue + p->prio);
__set_bit(p->prio, array->bitmap);
- array->nr_active++;
p->array = array;
}
@@ -229,7 +226,6 @@
prio_array_t* array = &rq->array;
list_add(&p->run_list, array->queue + p->prio);
__set_bit(p->prio, array->bitmap);
- array->nr_active++;
p->array = array;
}
@@ -1095,7 +1091,6 @@
p->prio = current->prio;
list_add_tail(&p->run_list, ¤t->run_list);
p->array = current->array;
- p->array->nr_active++;
rq->nr_running++;
}
} else {
next prev parent reply other threads:[~2004-06-07 14:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-06 15:39 [PATCH] Staircase Scheduler v6.3 for 2.6.7-rc2 Con Kolivas
2004-06-06 16:59 ` Jan Killius
2004-06-06 17:40 ` Felipe Alfaro Solana
2004-06-06 22:58 ` Con Kolivas
2004-06-06 20:43 ` Prakash K. Cheemplavam
2004-06-06 22:55 ` Con Kolivas
2004-06-06 20:59 ` Felipe Alfaro Solana
2004-06-06 22:57 ` Con Kolivas
2004-06-06 23:47 ` Con Kolivas
2004-06-07 13:56 ` William Lee Irwin III
2004-06-07 13:57 ` William Lee Irwin III
2004-06-07 14:04 ` William Lee Irwin III [this message]
2004-06-07 14:07 ` William Lee Irwin III
2004-06-07 15:00 ` William Lee Irwin III
2004-06-07 15:11 ` William Lee Irwin III
2004-06-07 19:57 ` Phy Prabab
2004-06-07 21:12 ` Con Kolivas
2004-06-07 21:40 ` Phy Prabab
2004-06-07 21:34 ` Con Kolivas
2004-06-08 0:06 ` Phy Prabab
2004-06-07 22:08 ` Con Kolivas
2004-06-08 2:50 ` Andrew Morton
2004-06-08 3:02 ` Con Kolivas
2004-06-08 3:05 ` Nick Piggin
2004-06-08 1:07 ` Con Kolivas
2004-06-08 5:51 ` Phy Prabab
2004-06-08 5:42 ` Phy Prabab
2004-06-08 5:50 ` Zwane Mwaikambo
2004-06-29 11:10 ` Pavel Machek
2004-06-29 11:14 ` Con Kolivas
2004-06-29 12:05 ` Felipe Alfaro Solana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040607140445.GA21007@holomorphy.com \
--to=wli@holomorphy.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.