All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
To: Stephen Smalley <sds@epoch.ncsc.mil>
Cc: Thomas Bleher <bleher@informatik.uni-muenchen.de>,
	SE-Linux <selinux@tycho.nsa.gov>
Subject: Re: support for fireflight reading /proc/NNN/fd and /proc/NNN/exe
Date: Tue, 8 Jun 2004 17:26:59 +0000	[thread overview]
Message-ID: <20040608172659.GA29575@lkcl.net> (raw)
In-Reply-To: <1086714639.32646.23.camel@moss-spartans.epoch.ncsc.mil>

On Tue, Jun 08, 2004 at 01:11:10PM -0400, Stephen Smalley wrote:
> On Mon, 2004-06-07 at 19:21, Thomas Bleher wrote:
> > Not the macro directly, otherwise all domains which use can_ps() will be
> > affected. If you really need that much access, you should probably add a
> > rule like
> >         allow fireflier_t file_type:file_class_set getattr;
> >         allow fireflier_t domain:{ socket_class_set fifo_file } getattr;
> > But this seems just too broad (see below).
> 
> Definitely too broad.  Use dontaudit rules to suppress the audit
> messages, and only allow it what it truly needs to function.
 
 i've spoken to martin and he accepted a patch on fireflight
 to restrict the stat operations to only those files where
 the symlink name begins with "socket:".

 if anyone with severe linux kernel knowledge (and isn't afraid
 to admit it) can forsee any problems with that approach, please do
 say so!

 martin says the code to do the /proc/<pid>/ walking he
 cut/paste from netstat so gawd only knows what horrors netstat
 gets up to.

 lsof i'd kinda expect to be better behaved and to know a few
 more kernel /proc tricks but for the life of me i can't work
 it out.  i seriously can't be bothered, the code is monster
 spaghetti and looks totally unmaintainable.

 l.


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

      reply	other threads:[~2004-06-08 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-07  8:22 support for fireflight reading /proc/NNN/fd and /proc/NNN/exe Luke Kenneth Casson Leighton
2004-06-07 20:59 ` Luke Kenneth Casson Leighton
2004-06-07 23:21   ` Thomas Bleher
2004-06-08  9:17     ` Luke Kenneth Casson Leighton
2004-06-08 17:11     ` Stephen Smalley
2004-06-08 17:26       ` Luke Kenneth Casson Leighton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040608172659.GA29575@lkcl.net \
    --to=lkcl@lkcl.net \
    --cc=bleher@informatik.uni-muenchen.de \
    --cc=sds@epoch.ncsc.mil \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.