All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Bruno Ducrot <ducrot@poupinou.org>
Cc: cpufreq@www.linux.org.uk
Subject: Re: [PATCH] replace for_each_cpu with for_each_cpu_mask (was Re: [PATCH] 2.6.5 speedstep on P4Ms)
Date: Thu, 10 Jun 2004 22:38:14 +0100	[thread overview]
Message-ID: <20040610213813.GT7964@redhat.com> (raw)
In-Reply-To: <20040610200427.GE13782@poupinou.org>

On Thu, Jun 10, 2004 at 10:04:27PM +0200, Bruno Ducrot wrote:

 > - --- linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c	2004/06/10 19:54:23	1.1
 > +++ linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c	2004/06/10 19:57:00
 > @@ -132,34 +132,28 @@ static int cpufreq_p4_target(struct cpuf
 >  #endif
 >  
 >  	/* notifiers */
 > - -	for_each_cpu(i) {
 > - -		if (cpu_isset(i, affected_cpu_map)) {
 > - -			freqs.cpu = i;
 > - -			cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
 > - -		}
 > +	for_each_cpu_mask(i, affected_cpu_map) {
 > +		freqs.cpu = i;
 > +		cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
 >  	}

That's a really funky looking patch. Care to rediff ? 8-)

		Dave

  reply	other threads:[~2004-06-10 21:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-08 17:15 [PATCH] 2.6.5 speedstep on P4Ms Christian Hoelbling
2004-06-08 15:30 ` Bruno Ducrot
2004-06-08 23:53   ` Christian Hoelbling
2004-06-09 15:47     ` Dominik Brodowski
2004-06-09 16:09       ` Bruno Ducrot
2004-06-09 16:29       ` Dave Jones
2004-06-09 16:53         ` Dominik Brodowski
2004-06-09 18:32           ` Mattia Dongili
2004-06-10  0:46       ` Christian Hoelbling
2004-06-10  8:30         ` Dominik Brodowski
2004-06-10 11:20           ` Dave Jones
2004-06-10  9:10         ` Bruno Ducrot
2004-06-10 15:37         ` Bruno Ducrot
2004-06-10 16:44           ` Dominik Brodowski
2004-06-10 19:26             ` [PATCH] Remove notify in speedstep_set_state [1/2] Bruno Ducrot
2004-06-10 19:28             ` [PATCH] Remove notify in speedstep_set_state [2/2] Bruno Ducrot
2004-06-10 19:35             ` [PATCH] security fix for speedstep-smi Bruno Ducrot
2004-06-10 19:44             ` [PATCH] 2.6.5 speedstep on P4Ms Bruno Ducrot
2004-06-10 20:04             ` [PATCH] replace for_each_cpu with for_each_cpu_mask (was Re: [PATCH] 2.6.5 speedstep on P4Ms) Bruno Ducrot
2004-06-10 21:38               ` Dave Jones [this message]
2004-06-11  9:55                 ` Bruno Ducrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040610213813.GT7964@redhat.com \
    --to=davej@redhat.com \
    --cc=cpufreq@www.linux.org.uk \
    --cc=ducrot@poupinou.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.