All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: schwab@suse.de, netdev@oss.sgi.com, yoshfuji@linux-ipv6.org
Subject: Re: 2.6.7-rc3: unregister_netdevice: waiting for tun0 to become free. Usage count = 1
Date: Sun, 13 Jun 2004 21:27:08 -0700	[thread overview]
Message-ID: <20040613212708.1903d54c.davem@redhat.com> (raw)
In-Reply-To: <20040614042216.GA28669@gondor.apana.org.au>

On Mon, 14 Jun 2004 14:22:16 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> OK, in that case either they all need to check whether idev is
> NULL before doing this or we'll need to fix ->ifdown to set the
> dev to something other than NULL.

That's correct, I don't exactly how to deal with that race
just yet.

> BTW in looking at this I've found two bugs in the dst code wrt
> cleaning up net devices.
> 
> 1. The code in dst_dev_event relies on the entries with dev in it
> getting onto the garbage list before it is called.  Unfortunately
> for routing entries, the flushing is done asynchronusly so it is
> entirely possible for the entries to get onto the garbage list after
> dst_dev_event has been called twice (DOWN and then UNREGISTER).
> 
> This is not fatal though since another GC run will pick them up in
> at most two minutes.  But the user may well be alarmed by those
> dreaded "waiting for..." errors.

Right.

> 2. dst_dev_event doesn't clean up dst->child at all.

DST object is disassembled at GC time, so I classift this just
like case #1 above.

  reply	other threads:[~2004-06-14  4:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040613121514.6b3c1c8a.davem@redhat.com>
2004-06-13 23:35 ` 2.6.7-rc3: unregister_netdevice: waiting for tun0 to become free. Usage count = 1 Herbert Xu
2004-06-13 23:41   ` Herbert Xu
2004-06-14  1:36     ` David S. Miller
2004-06-14  1:50       ` Herbert Xu
2004-06-14  4:07         ` David S. Miller
2004-06-14  4:22           ` Herbert Xu
2004-06-14  4:27             ` David S. Miller [this message]
2004-06-14  4:42               ` Herbert Xu
2004-06-14  4:47                 ` Herbert Xu
2004-06-14  4:43                   ` David S. Miller
2004-06-14  4:53                     ` Herbert Xu
2004-06-14 10:28             ` Herbert Xu
2004-06-14 12:44               ` Herbert Xu
2004-06-16 19:37                 ` Alexey Kuznetsov
2004-06-16 20:09                   ` David S. Miller
2004-06-16 20:37                     ` Alexey Kuznetsov
2004-06-16 20:47                       ` David S. Miller
2004-06-17  8:17                         ` Herbert Xu
2004-06-17  8:33                           ` Herbert Xu
2004-06-17 17:10                             ` David S. Miller
2004-06-17 17:24                               ` Alexey Kuznetsov
2004-06-17 17:53                                 ` David S. Miller
2004-06-17 19:07                                   ` Alexey Kuznetsov
2004-06-17 19:16                                     ` David S. Miller
2004-06-17 21:29                                     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040613212708.1903d54c.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    --cc=schwab@suse.de \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.