From: Christoph Hellwig <hch@lst.de>
To: sparclinux@vger.kernel.org
Subject: Re: sparc env monitorin vs tasklist_lock
Date: Tue, 15 Jun 2004 18:04:33 +0000 [thread overview]
Message-ID: <20040615180433.GA21929@lst.de> (raw)
In-Reply-To: <20040615172956.GA21361@lst.de>
On Tue, Jun 15, 2004 at 01:42:08PM -0400, Ben Collins wrote:
> On Tue, Jun 15, 2004 at 07:29:56PM +0200, Christoph Hellwig wrote:
> > Strange stuff going on here, bbc_envctrl.c and envctrl.c iterate over
> > the complete task list to check whether the thread has been killed,
> > yikes!
> >
> > I've attached a patch to convert it to the kthread infrastructure, but
> > it has been completely untested, not even compiled.
> >
> > p.s. the drivers also have other strangenesses like calling execve
> > directly instead of call_usermodehelper and the bbc driver having it's
>
> You took out the use of poll_interval, so wouldn't that cause the thread
> to eat up all the cpu with this patch?
Sorry, that was a bug then. This is really just a very crude draft
patch.
prev parent reply other threads:[~2004-06-15 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-15 17:29 sparc env monitorin vs tasklist_lock Christoph Hellwig
2004-06-15 17:42 ` Ben Collins
2004-06-15 18:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040615180433.GA21929@lst.de \
--to=hch@lst.de \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.