From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: 2.6.7-rc3: unregister_netdevice: waiting for tun0 to become free. Usage count = 1 Date: Wed, 16 Jun 2004 13:47:11 -0700 Sender: netdev-bounce@oss.sgi.com Message-ID: <20040616134711.499209c9.davem@redhat.com> References: <20040613234142.GA32329@gondor.apana.org.au> <20040613183622.3a814506.davem@redhat.com> <20040614015013.GA11048@gondor.apana.org.au> <20040613210725.70dbd016.davem@redhat.com> <20040614042216.GA28669@gondor.apana.org.au> <20040614102858.GA12343@gondor.apana.org.au> <20040614124402.GA28519@gondor.apana.org.au> <20040616193731.GB29781@ms2.inr.ac.ru> <20040616130950.6aadde3c.davem@redhat.com> <20040616203748.GA30675@ms2.inr.ac.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: herbert@gondor.apana.org.au, schwab@suse.de, netdev@oss.sgi.com, yoshfuji@linux-ipv6.org Return-path: To: Alexey Kuznetsov In-Reply-To: <20040616203748.GA30675@ms2.inr.ac.ru> Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Thu, 17 Jun 2004 00:37:48 +0400 Alexey Kuznetsov wrote: > Sort of. I think it should happen after killing reference to dst->dev: ... > but before dropping reference to dev: ... > So, I think it should look like: > > dst->dev = &loopback_dev; > dev_hold(&loopback_dev); > + synchronize_kernel(); > dev_put(dev); Perfect, that's what I put into my tree then, plus some comment.