All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: kai.engert@gmx.de
Cc: linux-kernel@vger.kernel.org, "Nemosoft Unv." <webcam@smcc.demon.nl>
Subject: Re: small patch: enable pwc usb camera driver
Date: Thu, 17 Jun 2004 12:58:51 -0700	[thread overview]
Message-ID: <20040617195851.GA23533@kroah.com> (raw)
In-Reply-To: <40D1909F.4090408@kuix.de>

On Thu, Jun 17, 2004 at 02:37:51PM +0200, Kai Engert wrote:
> Greg KH wrote:
> >On Tue, Jun 08, 2004 at 12:27:04AM +0200, Nemosoft Unv. wrote:
> >>... 
> >>Don't use this. It will BUG() your kernel hard, because of a double 
> >>free(). 
> 
> I confirm, if you disconnect the device / unload the driver, it doesn't 
> take long and the kernel reports an exception. My fault, sorry.
> 
> >... I'll wait for someone to send another patch fixing this one ...
> 
> I'm attaching a new patch:
> 
> - revert video device release code to original no-op,
>   using correct function signature.

Ick ick ick!  No, that's not the way to fix this.

Bah, time to mark the driver broken again...

greg k-h

      reply	other threads:[~2004-06-17 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-07 13:00 small patch: enable pwc usb camera driver Kai Engert
2004-06-07 20:20 ` Greg KH
2004-06-07 22:27   ` Nemosoft Unv.
2004-06-07 22:39     ` Greg KH
2004-06-17 12:37       ` Kai Engert
2004-06-17 19:58         ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040617195851.GA23533@kroah.com \
    --to=greg@kroah.com \
    --cc=kai.engert@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=webcam@smcc.demon.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.