From: maximilian attems <janitor@sternwelten.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] please comment on this patch
Date: Fri, 18 Jun 2004 09:43:07 +0000 [thread overview]
Message-ID: <20040618094307.GC21628@sputnik.stro.at> (raw)
In-Reply-To: <200406160257.i5G2vWLJ023048@sirius.cs.pdx.edu>
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Fri, 18 Jun 2004, Nicolas Kaiser wrote:
> * Kristen Carlson <kristenc@cs.pdx.edu>:
>
> > Here's a new patch, please let me know what you think.
>
> > /*
> > * Check for ESP card
> > */
> > -
> > - if (!check_region(info->port, 8) &&
> > - serial_in(info, UART_ESI_BASE) == 0xf3) {
> > +
> ^^^^
> > + if (serial_in(info, UART_ESI_BASE) == 0xf3) {
>
>
> Just nitpicking: Looks like trailing whitespace.
corrected 2 other occurrences for the kjt patch set.
a++ maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-06-18 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-16 2:57 [Kernel-janitors] please comment on this patch Kristen Carlson
2004-06-16 14:12 ` Matthew Wilcox
2004-06-16 16:48 ` Kristen Carlson
2004-06-17 3:38 ` Kristen Carlson
2004-06-17 5:24 ` Arnaldo Carvalho de Melo
2004-06-17 12:51 ` Matthew Wilcox
2004-06-18 1:41 ` Nicolas Kaiser
2004-06-18 9:43 ` maximilian attems [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040618094307.GC21628@sputnik.stro.at \
--to=janitor@sternwelten.at \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.