From: Christoph Hellwig <hch@infradead.org>
To: Brian Lazara <blazara@nvidia.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.7 and 2.4.27-pre6] new device support for forcedeth.c
Date: Sat, 19 Jun 2004 11:07:14 +0100 [thread overview]
Message-ID: <20040619100714.GA3554@infradead.org> (raw)
In-Reply-To: <1087629194.19311.24.camel@localhost.localdomain>
On Sat, Jun 19, 2004 at 12:13:14AM -0700, Brian Lazara wrote:
> +#ifndef free_netdev
> +#define free_netdev(dev) kfree(dev);
> +#endif
free_netdev isn't a macro in 2.6, so you're going to blow up nicely.
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_1 0x01C3
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_2 0x0066
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_3 0x00D6
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_4 0x0086
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_5 0x008C
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_6 0x00E6
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_7 0x00DF
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_8 0x0056
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_9 0x0057
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_10 0x0037
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_11 0x0038
The go to include/linux/pci_ids.h
> + * Function pointers based on descriptor version
> + */
> +int (*nv_alloc_rx)(struct net_device *dev);
> +int (*nv_start_xmit)(struct sk_buff *skb, struct net_device *dev);
> +void (*nv_tx_done)(struct net_device *dev);
> +void (*nv_rx_process)(struct net_device *dev);
Better to put them into the per-device data structures or you're screwed
if you have two of those in a system (and even if that's totally impossible
global variables like that are still bad style.
next prev parent reply other threads:[~2004-06-19 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-19 7:13 [PATCH 2.6.7 and 2.4.27-pre6] new device support for forcedeth.c Brian Lazara
2004-06-19 8:42 ` Kalin KOZHUHAROV
2004-06-19 10:07 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-27 20:33 Manfred Spraul
2004-06-28 15:38 Brian Lazara
2004-06-30 0:10 Ayaz Abdulla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040619100714.GA3554@infradead.org \
--to=hch@infradead.org \
--cc=blazara@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.