All of lore.kernel.org
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: "Moore, Eric Dean" <Emoore@lsil.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [ANNOUNCE] MPT Fusion driver 3.01.09 update
Date: Mon, 21 Jun 2004 18:23:03 +0100	[thread overview]
Message-ID: <20040621172303.GA12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E5704925040@exa-atlanta>

On Mon, Jun 21, 2004 at 01:09:43PM -0400, Moore, Eric Dean wrote:
> Somebody had submitted this change in the last week,
> along with the comment in that patch:
> 
> "The only way crap below could work..."

Yes?  Care to take a look at your definition of S64?  Now think for a moment
what it will produce on a big-endian box.

> I had not seen the patch on this mailing list. 
> I would like revert back to its previous bits since I don't see
> what was broken with it.  These headers in the lsi folder are 
> the mpi interface to the mpt firmware, and are bundled with 
> all operating systems, etc. window, netware, solaris, unixware, etc.

> > > +#if defined(unix) || defined(__arm) || defined(ALPHA)
> > > +
> > > +    typedef signed   int   S32;
> > > +    typedef unsigned int   U32;
> > > +
> > > +#else
> > > +
> > > +    typedef signed   long  S32;
> > > +    typedef unsigned long  U32;
> > > +
> > > +#endif

... and that is ugly beyond words.

  parent reply	other threads:[~2004-06-21 17:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-21 17:09 [ANNOUNCE] MPT Fusion driver 3.01.09 update Moore, Eric Dean
2004-06-21 17:21 ` Arjan van de Ven
2004-06-21 17:22 ` James Bottomley
2004-06-21 17:23 ` viro [this message]
2004-06-21 17:43   ` James Bottomley
     [not found] <0E3FA95632D6D047BA649F95DAB60E5704925095@exa-atlanta>
     [not found] ` <20040622101105.GA32761@infradead.org>
     [not found]   ` <20040622101450.GA610@infradead.org>
     [not found]     ` <20040622103409.GA782@infradead.org>
     [not found]       ` <20040622113916.GA1436@infradead.org>
2004-06-22 11:46         ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2004-06-21 18:43 Moore, Eric Dean
2004-06-21 17:53 Moore, Eric Dean
2004-06-21 16:19 Moore, Eric Dean
2004-06-21 16:16 Moore, Eric Dean
2004-06-21 16:32 ` James Bottomley
2004-06-21 16:50   ` viro
2004-06-21 17:11 ` Arjan van de Ven
2004-06-21 18:12 ` Christoph Hellwig
2004-06-23 16:13 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040621172303.GA12308@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=Emoore@lsil.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.