From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: SCSI Mailing List <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@steeleye.com>
Subject: PATCH [17/18] qla2xxx: Bus reset handler fixes
Date: Mon, 21 Jun 2004 23:01:03 -0700 [thread overview]
Message-ID: <20040622060103.GA8531@linux.local.home> (raw)
ChangeSet
1.1853 04/06/21 15:34:37 andrew.vasquez@apc.qlogic.com +1 -0
Fix incorrect return-code check in bus-reset error handler.
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
drivers/scsi/qla2xxx/qla_os.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
--- a/drivers/scsi/qla2xxx/qla_os.c 2004-06-21 15:40:37 -07:00
+++ b/drivers/scsi/qla2xxx/qla_os.c 2004-06-21 15:40:37 -07:00
@@ -147,7 +147,7 @@
static int qla2xxx_eh_device_reset(struct scsi_cmnd *);
static int qla2xxx_eh_bus_reset(struct scsi_cmnd *);
static int qla2xxx_eh_host_reset(struct scsi_cmnd *);
-static uint8_t qla2x00_loop_reset(scsi_qla_host_t *ha);
+static int qla2x00_loop_reset(scsi_qla_host_t *ha);
static int qla2x00_device_reset(scsi_qla_host_t *, fc_port_t *);
static int qla2x00_proc_info(struct Scsi_Host *, char *, char **,
@@ -1568,7 +1568,7 @@
}
if (qla2x00_wait_for_loop_ready(ha) == QLA_SUCCESS) {
- if (qla2x00_loop_reset(ha))
+ if (qla2x00_loop_reset(ha) == QLA_SUCCESS)
rval = SUCCESS;
}
@@ -1683,10 +1683,10 @@
* Returns:
* 0 = success
*/
-static uint8_t
+static int
qla2x00_loop_reset(scsi_qla_host_t *ha)
{
- uint8_t status = QLA_SUCCESS;
+ int status = QLA_SUCCESS;
uint16_t t;
os_tgt_t *tq;
reply other threads:[~2004-06-22 5:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040622060103.GA8531@linux.local.home \
--to=andrew.vasquez@qlogic.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.