All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Clemens Schwaighofer <cs@tequila.co.jp>
Cc: linux-kernel@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: 2.6.7 and khelper
Date: Thu, 24 Jun 2004 18:47:49 -0700	[thread overview]
Message-ID: <20040624184749.008358b0.akpm@osdl.org> (raw)
In-Reply-To: <40DB76F1.9010107@tequila.co.jp>

Clemens Schwaighofer <cs@tequila.co.jp> wrote:
>
> First of I have no idea what khelper actually does, but it seems to make
> a problem on my box.

It is a kernel thread which is used for making calls out to userspace
applications from within the kernel.

> I have a Debian/unstable box here (the same one that has these "fast
> clock problems with 2.6.7-mm1) and every night after the syslog restart
> the process with the id "4", which is khelper is reported to be
> respawning to fast.

Strange.  I assume that what's happening is that the children of khelper
are being created and are dying, and init is somehow seeing this happen. 
Maybe SIGCHLD, probably via wait4().  Perhaps init should be changed to not
complain about processes which it did't parent.  But then, that should
already be the case.


Could you please apply the below debug patch, then send us all the relevant
syslog output, including the messages from init?

Thanks.


diff -puN kernel/kmod.c~khelper-child-sequence kernel/kmod.c
--- 25/kernel/kmod.c~khelper-child-sequence	2004-06-24 18:42:34.351391688 -0700
+++ 25-akpm/kernel/kmod.c	2004-06-24 18:45:01.186069424 -0700
@@ -155,6 +155,9 @@ static int ____call_usermodehelper(void 
 	struct subprocess_info *sub_info = data;
 	int retval;
 	cpumask_t mask = CPU_MASK_ALL;
+	static int call_umh_id;
+
+	sprintf(current->comm, "call_umh%d\n", call_umh_id++);
 
 	/* Unblock all signals. */
 	flush_signals(current);
@@ -182,6 +185,9 @@ static int wait_for_helper(void *data)
 	struct subprocess_info *sub_info = data;
 	pid_t pid;
 	struct k_sigaction sa;
+	static int khelper_id;
+
+	sprintf(current->comm, "waiter%d", khelper_id++);
 
 	/* Install a handler: if SIGCLD isn't handled sys_wait4 won't
 	 * populate the status, but will return -ECHILD. */
_



  reply	other threads:[~2004-06-25  1:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-25  0:50 2.6.7 and khelper Clemens Schwaighofer
2004-06-25  1:47 ` Andrew Morton [this message]
2004-06-25 10:04   ` Clemens Schwaighofer
2004-06-25 10:56   ` Matthias Urlichs
2004-06-28  0:29     ` Clemens Schwaighofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040624184749.008358b0.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=cs@tequila.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.