From: viro@parcelfarce.linux.theplanet.co.uk
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Oops with 2.6.7-bk
Date: Thu, 24 Jun 2004 22:24:17 +0100 [thread overview]
Message-ID: <20040624212417.GG12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1088111809.4160.1.camel@pegasus>
On Thu, Jun 24, 2004 at 11:16:49PM +0200, Marcel Holtmann wrote:
> I got this oops on boot with the latest Bitkeeper snapshot of 2.6.7
Memory corruption in generic_readlink(), now that we use nd->depth instead
of current->link_count. Fix follows:
--- fs/namei.c Thu Jun 24 16:06:45 2004
+++ fs/namei.c-fix Thu Jun 24 16:07:24 2004
@@ -2197,7 +2197,9 @@
int generic_readlink(struct dentry *dentry, char __user *buffer, int buflen)
{
struct nameidata nd;
- int res = dentry->d_inode->i_op->follow_link(dentry, &nd);
+ int res;
+ nd.depth = 0;
+ res = dentry->d_inode->i_op->follow_link(dentry, &nd);
if (!res) {
res = vfs_readlink(dentry, buffer, buflen, nd_get_link(&nd));
if (dentry->d_inode->i_op->put_link)
next prev parent reply other threads:[~2004-06-24 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-24 21:16 Oops with 2.6.7-bk Marcel Holtmann
2004-06-24 21:24 ` viro [this message]
2004-06-24 22:41 ` generic_readlink() - patch WFM David Eger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040624212417.GG12308@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.