From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: agruen@suse.de, netdev@oss.sgi.com
Subject: Re: [NAT-T] NON-IKE encapsulation
Date: Fri, 25 Jun 2004 10:12:31 -0700 [thread overview]
Message-ID: <20040625101231.6f6b2f12.davem@redhat.com> (raw)
In-Reply-To: <20040624123603.GA1241@gondor.apana.org.au>
On Thu, 24 Jun 2004 22:36:03 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> I'm having trouble understanding why we need to increase alen by
> two bytes for NON-IKE. As far as I can see it's adding two bytes
> of random data to the end of the packet. Is there something
> obvious that I'm missing?
I now think it's trying to account for the udpdata32[] header area.
But that's not 2 bytes, it's (2 * sizeof(u32)) or 8 bytes.
The ESP added headers amount to esp->auth.icv_trunc_len + 8 in
this case, so changing the "alen += 2;" into "alen += 8;" seems
more appropriate.
What do you think Herbert? Does it make sense now?
next prev parent reply other threads:[~2004-06-25 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-24 12:36 [NAT-T] NON-IKE encapsulation Herbert Xu
2004-06-24 19:46 ` David S. Miller
2004-06-24 21:41 ` Herbert Xu
2004-06-25 17:12 ` David S. Miller [this message]
2004-06-25 21:57 ` Herbert Xu
2004-06-25 22:09 ` David S. Miller
2004-06-25 22:13 ` Andreas Gruenbacher
2004-06-25 22:12 ` David S. Miller
2004-06-25 23:30 ` Andreas Gruenbacher
2004-06-26 0:47 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040625101231.6f6b2f12.davem@redhat.com \
--to=davem@redhat.com \
--cc=agruen@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.