All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] kill obsolete typedefs and wrappers from tmscsim
Date: Sat, 26 Jun 2004 13:17:01 +0200	[thread overview]
Message-ID: <20040626111701.GA15170@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.60.0406252022400.3953@poirot.grange>

> >That'll happen sooner or later :)
> 
> So, why not now?:-)

Okay, okay - you've won :)

> Sure, that's easy!:-) I kept capitals initially, because all functions are 
> called like FindDCB, DoingSRB_Done, etc. But if we rename dc390_dcb into 
> dc390_lun, we would have to rename all respective functions, but that's 
> a bit too much, I think. So, is it ok to just "smallify" the types, going 
> the Middle Way?:-)

Yes.

> Do you want to rediff your 3rd patch yourself or should I do it? 

I can rediff it.

> Essentially, as you know, up to now the "old" EH code was used by tmscsim. 
> Switching to the "new" one seems a pretty essential change.

No.  Old EH is completely gone in 2.6.  The tmscsim driver claims to
implement new EH but gets it wrong currently..

> Is there a way 
> I could test it a bit? I can now boot and run from IDE, loading tmscsim as 
> a module, to which I have a disk and a CD-ROM connected. How can I 
> exercise eh-paths a bit without destroying the hardware?:-)

A good way to test EH is to improperly terminate the bus and wait for
failures to happen or similar things.


  reply	other threads:[~2004-06-26 11:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-24  8:15 [PATCH] kill obsolete typedefs and wrappers from tmscsim Christoph Hellwig
2004-06-24 22:44 ` Guennadi Liakhovetski
2004-06-25  9:50   ` Christoph Hellwig
2004-06-25 19:42     ` Guennadi Liakhovetski
2004-06-26 11:17       ` Christoph Hellwig [this message]
2004-06-26 22:32         ` Guennadi Liakhovetski
2004-07-04 21:37         ` Guennadi Liakhovetski
2004-07-19 20:09           ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040626111701.GA15170@lst.de \
    --to=hch@lst.de \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.