From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] add kfree(ha) to drivers/scsi/ips.c
Date: Sat, 26 Jun 2004 13:53:50 +0000 [thread overview]
Message-ID: <20040626135349.GA1706@masina> (raw)
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
Hi.
This has been on TODO as long as i remember, lets try to fix it.
Compile tested.
ips_init_phase1 and ips_init_phase2 call ips_abort_init on failure, but
it doesn't free 'ha'.
'ha' should be released on ips_release.
Needs review from someone who knows stuff a bit more.
Signed-off-by: Domen Puncer <domen@coderock.org>
--- c/drivers/scsi/ips.c 2004-06-16 07:18:38.000000000 +0200
+++ a/drivers/scsi/ips.c 2004-06-26 15:36:14.000000000 +0200
@@ -729,6 +729,7 @@ ips_release(struct Scsi_Host *sh)
/* free IRQ */
free_irq(ha->irq, ha);
+ kfree(ha);
IPS_REMOVE_HOST(sh);
scsi_host_put(sh);
@@ -6946,6 +6947,7 @@ ips_abort_init(ips_ha_t * ha, int index)
{
ha->active = 0;
ips_free(ha);
+ kfree(ha);
ips_ha[index] = 0;
ips_sh[index] = 0;
return -1;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2004-06-26 13:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040626135349.GA1706@masina \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.