From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/19] New set of input patches
Date: Mon, 28 Jun 2004 09:51:24 +0200 [thread overview]
Message-ID: <20040628075124.GA1507@ucw.cz> (raw)
In-Reply-To: <200406280213.58978.dtor_core@ameritech.net>
On Mon, Jun 28, 2004 at 02:13:58AM -0500, Dmitry Torokhov wrote:
> > IMO drivers have no bussiness messing with the serio locks. We could use
> > 'plug' and 'unplug' functions like the network driver use, or handle it
> > inside the driver, but taking the lock is the wrong thing to do.
>
> OK, I just don't want to introduce another lock just for that...
I think a bit in flags "PSMOUSE_ENABLED", like we have the
"ATKBD_ENABLED" bit might be just fine - handle the interrupt, but throw
away the data during the protocol switch. We aren't interested in the
data anyway.
> > > 15-synaptics-passthrough-handling.patch
> > > - If data looks like a pass-through packet and tuchpad has
> > > pass-through capability do not pass it to the main handler
> > > if child port is disconnected.
> >
> > I'll have to look closer on this one - I think we want to pass the data
> > to the serio layer even if there is no driver listening on the
> > passthrough serio.
>
> We probably should issue serio_interrupt on child port to force rescan but
> that packet has no business in parent's motion handling routine and that's
> what this patch tries to fix. Anyway, I will look at it more later.
Indeed, we need it for the rescan. It shouldn't be that hard to fix at
once.
>
> > > (*) These patches have also been sent to Greg KH.
> >
> > Did he accept them already?
>
> No, not yet. He promised to take a look at platoform_device_register_simple by
> the end of the week but I guess kernel.bkbits.net troubles might intervene...
> And other 2 I just send out today.
Ok. I'll wait then.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-06-28 7:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-28 5:08 [PATCH 0/19] New set of input patches Dmitry Torokhov
2004-06-28 5:09 ` [PATCH 1/19] psmouse state locking Dmitry Torokhov
2004-06-28 5:10 ` [PATCH 2/19] serio connect/disconnect mandatory Dmitry Torokhov
2004-06-28 5:11 ` [PATCH 3/19] serio renames 1 Dmitry Torokhov
2004-06-28 5:12 ` [PATCH 4/19] serio renames 2 Dmitry Torokhov
2004-06-28 5:13 ` [PATCH 5/19] serio dynamic allocation Dmitry Torokhov
2004-06-28 5:14 ` [PATCH 6/19] serio avoid recursion Dmitry Torokhov
2004-06-28 5:15 ` [PATCH 7/19] serio sysfs intergration Dmitry Torokhov
2004-06-28 5:16 ` [PATCH 8/19] serio rebind Dmitry Torokhov
2004-06-28 5:17 ` PATCH 9/19] serio manual bind Dmitry Torokhov
2004-06-28 5:17 ` [PATCH 10/19] serio_raw driver Dmitry Torokhov
2004-06-28 5:19 ` [PATCH 11/19] add platform_device_register_simple Dmitry Torokhov
2004-06-28 5:19 ` [PATCH 12/19] convert i8042 into a platform device Dmitry Torokhov
2004-06-28 5:21 ` [PATCH 13/19] more platform device conversions Dmitry Torokhov
2004-06-28 5:22 ` [PATCH 14/19] bind serio ports and their parents Dmitry Torokhov
2004-06-28 5:23 ` [PATCH 15/19] synaptics passthrough handling Dmitry Torokhov
2004-06-28 5:24 ` [PATCH 16/19] add bus' default driver attributes Dmitry Torokhov
2004-06-28 5:25 ` [PATCH 17/19] serio use bus' default driver/device attributes Dmitry Torokhov
2004-06-28 5:26 ` [PATCH 18/19] add driver_find Dmitry Torokhov
2004-06-28 5:27 ` [PATCH 19/19] serio use driver_find Dmitry Torokhov
2004-06-28 6:52 ` [PATCH 0/19] New set of input patches Vojtech Pavlik
2004-06-28 7:13 ` Dmitry Torokhov
2004-06-28 7:51 ` Vojtech Pavlik [this message]
2004-06-28 10:32 ` Neil Brown
2004-06-28 12:13 ` Vojtech Pavlik
-- strict thread matches above, loose matches on Subject: below --
2004-06-28 10:05 Sau Dan Lee
2004-06-28 14:54 Dmitry Torokhov
2004-06-28 15:07 ` Vojtech Pavlik
2004-06-29 7:01 ` Dmitry Torokhov
2004-06-29 7:25 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628075124.GA1507@ucw.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.