From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: hch@lst.de, netdev@oss.sgi.com
Subject: Re: old NLMSG_OK fix
Date: Mon, 28 Jun 2004 11:22:58 -0700 [thread overview]
Message-ID: <20040628112258.31ed64f1.davem@redhat.com> (raw)
In-Reply-To: <E1Besfp-0004hd-00@gondolin.me.apana.org.au>
On Mon, 28 Jun 2004 19:43:37 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> David S. Miller <davem@redhat.com> wrote:
> > On Sun, 27 Jun 2004 19:15:52 +0200
> > Christoph Hellwig <hch@lst.de> wrote:
> >
> >> http://oss.sgi.com/projects/netdev/archive/2000-09/msg00001.html
> >
> > It works because there is always 16 bytes of scratch at the end of an
> > SKB more than was allocated for the actual data. So blindly deref'ing
> > the nlmsg_len value is fine here.
>
> Yes but this is also used by user-space appliations where this scratch
> space may not exist. NETLINK messages can travel from one application
> to another so exploits are possible.
You're right, thanks for pointing this out. I'll add it to my tree.
prev parent reply other threads:[~2004-06-28 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-31 16:04 old NLMSG_OK fix Christoph Hellwig
2004-06-27 17:15 ` Christoph Hellwig
2004-06-28 3:51 ` David S. Miller
2004-06-28 9:43 ` Herbert Xu
2004-06-28 18:22 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628112258.31ed64f1.davem@redhat.com \
--to=davem@redhat.com \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.