From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: check_region question
Date: Mon, 28 Jun 2004 14:42:40 +0000 [thread overview]
Message-ID: <20040628144240.GB24005@nd47> (raw)
[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]
On 28/06/04 11:57 +0200, Carlo Perassi wrote:
> Hi
> compiling a new 2.6.7 I got
> drivers/ide/pci/trm290.c:376: warning: `check_region' is deprecated
> drivers/char/specialix.c:290: warning: `check_region' is deprecated
>
> So I searched and found (see the end of the email) a lot of places where
> that call occours.
> I guess this is not (always) a "search/replace" task so my question is
>
> (a)
> if a call like
> check_region(s, n)
> should be replaced with
> request_region(s, n, name)
> (where name is something like hwif->name)
> and
> (b)
> if an if statement like
> if (check_region(s, n))
> should be replaced with
> if (!request_region(s, n, name))
> is there something more than ((a) + (b)) to convert a deprecated section
> of code?
It's not that simple.
There's been some recent discussion about this here, and i'm sure you
can find old check_region patches which were wrong, and a nice
description of what is wrong.
Basically, check_region() was used before request_region(), now you
have to check you didn't request a region that you shouldn't.
And that request_region() that was in code before usually get's removed.
(I hope i make some sense)
> I found some old patches which should be good examples but I don't know
> this topic enough to make a general theory.
>
> Thanks.
>
...
> sound/oss/waveartist.c:1349
> sound/oss/pss.c:191
...
Don't bother with these, they'll probably get removed in 2.7.x
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-06-28 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-28 14:42 Domen Puncer [this message]
2004-06-28 15:54 ` [Kernel-janitors] Re: check_region question Carlo Perassi
2004-07-05 15:07 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628144240.GB24005@nd47 \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.