From: David Eger <eger@havoc.gtf.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.7-mm3] cirrusfb: minor fixes
Date: Mon, 28 Jun 2004 17:59:48 -0400 [thread overview]
Message-ID: <20040628215948.GA12415@havoc.gtf.org> (raw)
In-Reply-To: <20040628212727.A23504@electric-eye.fr.zoreil.com>
On Mon, Jun 28, 2004 at 09:27:27PM +0200, Francois Romieu wrote:
> Testers welcome.
>
> - fix unbalanced invocation of pci_enable_device();
> - leaks plugged in cirrusfb_zorro_setup();
> - move framebuffer_release() into cirrusfb_{pci/zorro}_unmap() to balance
> cirrusfb_{pci/zorro}_setup();
> - make cirrusfb_{pci/zorro}_setup() return adequate error codes when
> something fails;
> - cirrusfb_zorro_unmap: iounmap() now take as argument values previously
> returned by ioremap().
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Your patch looks great.
Not only does it look great, with it X and cirrusfb now play nice with
each other! Andrew, please apply. Feel free to add my:
Signed-off-by: David Eger <eger@havoc.gtf.org>
On another note...
pci_request_regions() replaces request_mem_region()...
looks like virtually all of the FB drivers have suffered from bit
rot. I guess that's what you get when people just look at code in
drivers/video/ to copy..
-dte
next prev parent reply other threads:[~2004-06-28 21:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-27 6:31 2.6.7-mm3 Andrew Morton
2004-06-27 9:04 ` 2.6.7-mm3 Joshua Kwan
2004-06-27 11:38 ` 2.6.7-mm3 [broken serial console and Kernel BUG on dual Opteron] R. J. Wysocki
2004-06-28 7:19 ` Andrew Morton
2004-06-28 19:18 ` R. J. Wysocki
2004-06-28 19:29 ` 2.6.7-mm3: Kernel BUG on dual Opteron with DEBUG_SLAB R. J. Wysocki
2004-06-28 23:12 ` Andrew Morton
2004-06-27 14:17 ` [patch] 2.6.7-mm3 ALSA gus compile error Adrian Bunk
2004-06-27 22:51 ` 2.6.7-mm3 Joseph Fannin
2004-06-28 15:03 ` 2.6.7-mm3 (compile stats) John Cherry
2004-06-28 19:27 ` [PATCH 2.6.7-mm3] cirrusfb: minor fixes Francois Romieu
2004-06-28 21:59 ` David Eger [this message]
2004-06-28 22:42 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628215948.GA12415@havoc.gtf.org \
--to=eger@havoc.gtf.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.