From: Jeff Garzik <jgarzik@redhat.com>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oliver@neukum.org>,
Pete Zaitcev <zaitcev@redhat.com>,
greg@kroah.com, arjanv@redhat.com, tburke@redhat.com,
linux-kernel@vger.kernel.org, mdharm-usb@one-eyed-alien.net,
david-b@pacbell.net
Subject: Re: drivers/block/ub.c
Date: Mon, 28 Jun 2004 19:58:22 -0400 [thread overview]
Message-ID: <20040628235822.GD29883@devserv.devel.redhat.com> (raw)
In-Reply-To: <20040627154515.GI5526@pclin040.win.tue.nl>
On Sun, Jun 27, 2004 at 05:45:15PM +0200, Andries Brouwer wrote:
> I still prefer writing explicitly what happens.
This is my preference for the implementation of conversions to and from
what I call 'scsi endian'.
Personally, I am pondering creation and use of cpu_to_scsiXX() and
scsiXX_to_cpu() static inline helper functions in my code, because
I'm tired of hand-coding conversions for {read,write}{6,10,12,16}.
Further, the value I see in direct cdb-to-something conversions has
declined over time. I now prefer the more clear
* scsi-to-u32
* u32-to-something
operations as preferred to a single
* scsi-to-something
operation that's hand-coded and frequently gets corner cases wrong.
Jeff
next prev parent reply other threads:[~2004-06-28 23:59 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-26 20:06 drivers/block/ub.c Pete Zaitcev
2004-06-26 20:12 ` drivers/block/ub.c Matthew Dharm
2004-06-27 2:08 ` drivers/block/ub.c Pete Zaitcev
2004-06-27 3:30 ` drivers/block/ub.c Matthew Dharm
2004-07-12 0:10 ` [usb-storage] drivers/block/ub.c Pat LaVarre
2004-06-26 20:35 ` drivers/block/ub.c Oliver Neukum
2004-06-26 21:41 ` drivers/block/ub.c David S. Miller
2004-06-26 21:56 ` drivers/block/ub.c Oliver Neukum
2004-06-26 22:07 ` drivers/block/ub.c David S. Miller
2004-06-26 22:36 ` drivers/block/ub.c Oliver Neukum
2004-06-26 23:20 ` drivers/block/ub.c David S. Miller
2004-06-27 4:31 ` drivers/block/ub.c Oliver Neukum
2004-06-27 6:34 ` drivers/block/ub.c David S. Miller
2004-06-27 10:42 ` drivers/block/ub.c Oliver Neukum
2004-06-27 21:26 ` drivers/block/ub.c David S. Miller
2004-06-28 14:15 ` drivers/block/ub.c Scott Wood
2004-06-28 20:25 ` drivers/block/ub.c David S. Miller
2004-06-28 20:48 ` drivers/block/ub.c Scott Wood
2004-06-28 20:58 ` drivers/block/ub.c David S. Miller
2004-06-28 20:50 ` drivers/block/ub.c Matthew Dharm
2004-06-28 20:59 ` drivers/block/ub.c David S. Miller
2004-06-28 21:01 ` drivers/block/ub.c Pete Zaitcev
2004-06-28 23:52 ` drivers/block/ub.c Matthew Dharm
2004-06-28 20:57 ` drivers/block/ub.c Oliver Neukum
2004-06-28 21:03 ` drivers/block/ub.c David S. Miller
2004-06-28 21:18 ` drivers/block/ub.c Scott Wood
2004-06-28 22:22 ` drivers/block/ub.c David S. Miller
2004-06-28 22:31 ` drivers/block/ub.c Scott Wood
2004-06-28 22:40 ` drivers/block/ub.c Roland Dreier
2004-06-29 1:54 ` drivers/block/ub.c Robert White
2004-06-29 2:15 ` drivers/block/ub.c David S. Miller
2004-06-29 2:49 ` drivers/block/ub.c Robert White
2004-06-29 18:31 ` drivers/block/ub.c Andy Isaacson
2004-07-05 10:01 ` drivers/block/ub.c Roman Zippel
2004-06-29 7:12 ` drivers/block/ub.c Vojtech Pavlik
2004-06-29 1:39 ` drivers/block/ub.c Robert White
2004-06-29 17:02 ` drivers/block/ub.c Kurt Garloff
2004-06-26 22:54 ` drivers/block/ub.c Andries Brouwer
2004-06-26 22:59 ` drivers/block/ub.c Oliver Neukum
2004-06-26 23:08 ` drivers/block/ub.c Andries Brouwer
2004-06-27 5:04 ` drivers/block/ub.c Oliver Neukum
2004-06-27 14:08 ` drivers/block/ub.c Andries Brouwer
2004-06-27 14:24 ` drivers/block/ub.c Oliver Neukum
2004-06-27 15:19 ` drivers/block/ub.c Alan Stern
2004-06-27 15:45 ` drivers/block/ub.c Andries Brouwer
2004-06-28 23:58 ` Jeff Garzik [this message]
2004-06-28 0:10 ` drivers/block/ub.c Pete Zaitcev
2004-06-28 16:01 ` drivers/block/ub.c Alan Stern
2004-06-27 15:23 ` drivers/block/ub.c Andries Brouwer
2004-06-27 16:11 ` drivers/block/ub.c Oliver Neukum
2004-06-26 22:46 ` drivers/block/ub.c Oliver Neukum
2004-06-27 3:52 ` drivers/block/ub.c Alan Stern
2004-06-27 4:05 ` drivers/block/ub.c Alan Stern
2004-06-27 5:02 ` drivers/block/ub.c Greg KH
2004-06-27 15:23 ` drivers/block/ub.c Alan Stern
2004-06-27 20:29 ` drivers/block/ub.c Pete Zaitcev
2004-06-27 21:03 ` drivers/block/ub.c Matthew Dharm
2004-06-28 15:40 ` drivers/block/ub.c Alan Stern
2004-06-28 16:42 ` drivers/block/ub.c Oliver Neukum
2004-06-28 19:50 ` drivers/block/ub.c Alan Stern
2004-06-27 5:35 ` drivers/block/ub.c Matthew Dharm
2004-06-27 15:28 ` drivers/block/ub.c Alan Stern
2004-06-27 22:56 ` drivers/block/ub.c David Brownell
2004-06-27 23:43 ` drivers/block/ub.c Pete Zaitcev
2004-06-28 15:05 ` drivers/block/ub.c David Brownell
2004-06-28 15:56 ` drivers/block/ub.c Alan Stern
2004-06-28 16:23 ` drivers/block/ub.c David Brownell
2004-06-28 16:46 ` drivers/block/ub.c Oliver Neukum
2004-06-28 17:13 ` drivers/block/ub.c David Brownell
[not found] ` <mailman.1088290201.14081.linux-kernel2news@redhat.com>
2004-06-27 23:57 ` drivers/block/ub.c Pete Zaitcev
2004-06-29 11:05 ` drivers/block/ub.c Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628235822.GD29883@devserv.devel.redhat.com \
--to=jgarzik@redhat.com \
--cc=aebr@win.tue.nl \
--cc=arjanv@redhat.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
--cc=tburke@redhat.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.