From: David Eger <eger@havoc.gtf.org>
To: akpm@osdl.org
Cc: linux-fbdev-devel@lists.sourceforge.net, Jurriaan <thunder7@xs4all.nl>
Subject: [PATCH] radeonfb: 16bpp copyarea() fixed!
Date: Tue, 29 Jun 2004 05:36:00 -0400 [thread overview]
Message-ID: <20040629093559.GA22557@havoc.gtf.org> (raw)
Dear Andrew,
It turns out the bug was due to my mis-copying a certain set of
flags from the x.org tree. The fix is as follows. Thanks for not
accepting an ugly work around :-) Please see that this gets to
mainline.
-dte
radeonfb: fix 16bpp copyarea() bug
Signed-off-by: David Eger <eger@havoc.gtf.org>
diff -Nru a/drivers/video/aty/radeon_accel.c b/drivers/video/aty/radeon_accel.c
--- a/drivers/video/aty/radeon_accel.c 2004-06-29 11:21:26 +02:00
+++ b/drivers/video/aty/radeon_accel.c 2004-06-29 11:21:26 +02:00
@@ -71,9 +71,10 @@
radeon_fifo_wait(3);
OUTREG(DP_GUI_MASTER_CNTL,
rinfo->dp_gui_master_cntl /* i.e. GMC_DST_32BPP */
+ | GMC_BRUSH_NONE
| GMC_SRC_DSTCOLOR
| ROP3_S
- | DP_SRC_RECT );
+ | DP_SRC_SOURCE_MEMORY );
OUTREG(DP_WRITE_MSK, 0xffffffff);
OUTREG(DP_CNTL, (xdir>=0 ? DST_X_LEFT_TO_RIGHT : 0)
| (ydir>=0 ? DST_Y_TOP_TO_BOTTOM : 0));
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
reply other threads:[~2004-06-29 9:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040629093559.GA22557@havoc.gtf.org \
--to=eger@havoc.gtf.org \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=thunder7@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.