From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com
Subject: Re: Check connect address in NETLINK
Date: Wed, 30 Jun 2004 15:36:06 -0700 [thread overview]
Message-ID: <20040630153606.3493581b.davem@redhat.com> (raw)
In-Reply-To: <20040630124050.GA1619@gondor.apana.org.au>
Why don't you combine the two "ERR_PTR(-ECONNREFUSED)" tests
into one test like:
if ((nlk->pid == 0 && !nlk->data_ready) ||
(sock->sk_state == NELTINK_CONNECTED &&
nlk->dst_pid != nlk_sk(ssk)->pid)) {
sock_put(sock);
return ERR_PTR(-ECONNREFUSED);
}
so we don't have two copies of the "sock_put(); return ERR_PTR()"
thing emitted by the compiler?
next prev parent reply other threads:[~2004-06-30 22:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-28 23:14 Check connect address in NETLINK Herbert Xu
2004-06-29 0:30 ` David S. Miller
2004-06-29 2:09 ` Herbert Xu
2004-06-29 8:22 ` Alexey Kuznetsov
2004-06-29 8:45 ` Herbert Xu
2004-06-29 11:14 ` Alexey Kuznetsov
2004-06-29 11:18 ` Herbert Xu
2004-06-30 11:27 ` Herbert Xu
2004-06-30 12:00 ` Alexey Kuznetsov
2004-06-30 12:08 ` Herbert Xu
2004-06-30 12:14 ` Alexey Kuznetsov
2004-06-30 12:40 ` Herbert Xu
2004-06-30 22:36 ` David S. Miller [this message]
2004-06-30 23:01 ` Herbert Xu
2004-07-05 22:46 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040630153606.3493581b.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.