From: Sven Luther <sven.luther@wanadoo.fr>
To: Adrian Cox <adrian@humboldt.co.uk>
Cc: Sven Luther <sven.luther@wanadoo.fr>, linuxppc-dev@lists.linuxppc.org
Subject: Re: Pegasos 2 support patch ...
Date: Wed, 30 Jun 2004 18:23:23 +0200 [thread overview]
Message-ID: <20040630162323.GA28483@pegasos> (raw)
In-Reply-To: <1088611966.28598.52.camel@localhost>
On Wed, Jun 30, 2004 at 05:12:46PM +0100, Adrian Cox wrote:
> On Wed, 2004-06-30 at 16:50, Sven Luther wrote:
> > static ide_hwif_t *ide_hwif_configure(struct pci_dev *dev,
> > ide_pci_device_t *d, ide_hwif_t *mate, int port, int irq)
> >
> > Would it not be better in my case to call ide_hwif_configure with the
> > right irq ? Or do i misunderstand what you had in mind ?
>
> It shouldn't make much difference - I only suggested ide_hwif_configure
> because it already contains flag checking code.
I am not sure if it works for me, but in your case, would the right
solution not be to have d->init_chipset return the irq ?
Friendly,
Sven Luther
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-06-30 16:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-29 16:50 Pegasos 2 support patch Sven Luther
2004-06-29 20:42 ` Sven Luther
2004-06-30 2:57 ` Benjamin Herrenschmidt
2004-06-30 6:00 ` Sven Luther
2004-06-30 8:10 ` Geert Uytterhoeven
2004-06-30 8:21 ` Sven Luther
2004-06-30 9:18 ` Adrian Cox
2004-06-30 9:30 ` Sven Luther
2004-06-30 9:40 ` Adrian Cox
2004-06-30 9:45 ` Sven Luther
2004-06-30 15:50 ` Sven Luther
2004-06-30 16:12 ` Adrian Cox
2004-06-30 16:23 ` Sven Luther [this message]
2004-06-30 16:39 ` Adrian Cox
2004-06-30 18:52 ` Sven Luther
2004-06-30 19:05 ` Adrian Cox
2004-06-30 19:38 ` Sven Luther
2004-07-01 7:59 ` Geert Uytterhoeven
2004-07-01 8:42 ` Adrian Cox
2004-07-01 8:48 ` Geert Uytterhoeven
2004-07-01 8:57 ` Sven Luther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040630162323.GA28483@pegasos \
--to=sven.luther@wanadoo.fr \
--cc=adrian@humboldt.co.uk \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.