From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266079AbUGAQwP (ORCPT ); Thu, 1 Jul 2004 12:52:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266101AbUGAQwP (ORCPT ); Thu, 1 Jul 2004 12:52:15 -0400 Received: from waste.org ([209.173.204.2]:20638 "EHLO waste.org") by vger.kernel.org with ESMTP id S266079AbUGAQwJ (ORCPT ); Thu, 1 Jul 2004 12:52:09 -0400 Date: Thu, 1 Jul 2004 11:52:01 -0500 From: Matt Mackall To: Jeff Moyer Cc: linux-kernel@vger.kernel.org Subject: Re: netconsole hangs w/ alt-sysrq-t Message-ID: <20040701165201.GF25826@waste.org> References: <16527.42815.447695.474344@segfault.boston.redhat.com> <20040428140353.GC28459@waste.org> <16527.47765.286783.249944@segfault.boston.redhat.com> <20040428142753.GE28459@waste.org> <16527.63123.869014.733258@segfault.boston.redhat.com> <16604.18881.850162.785970@segfault.boston.redhat.com> <20040625232711.GE25826@waste.org> <16608.12233.39964.940020@segfault.boston.redhat.com> <20040628151954.GH25826@waste.org> <16608.20014.220537.339589@segfault.boston.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16608.20014.220537.339589@segfault.boston.redhat.com> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2004 at 12:58:22PM -0400, Jeff Moyer wrote: > ==> Regarding Re: netconsole hangs w/ alt-sysrq-t; Matt Mackall adds: > mpm> No, I think we get to this on the non-NAPI route as well. The ->poll > mpm> check keeps us from filtering twice. > > I'll have to take your word for it on this one, as I can't find a way into > this code for the non-napi case. Would anyone care to give an > authoritative answer on this? I could be mistaken, but that's my recollection from last summer. Hopefully I'll have some spare cycles for this next week. > One other thing we might consider is adding a call to touch_nmi_watchdog() > to zap_completion_queue. Not sure how I feel about that yet. If we can't get out of the guts of netpoll in a timely fashion, then perhaps that's an indication that the watchdog should indeed fire. Describe the scenario where you think we should do this, please. -- Mathematics is the supreme nostalgia of our time.