From: Pavel Machek <pavel@ucw.cz>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide-taskfile.c fixups/cleanups part #2 [1/9]
Date: Fri, 2 Jul 2004 14:20:04 +0200 [thread overview]
Message-ID: <20040702122004.GC12889@elf.ucw.cz> (raw)
In-Reply-To: <200406301724.05862.bzolnier@elka.pw.edu.pl>
Hi!
> diff -puN drivers/ide/ide-taskfile.c~ide_tf_pio_out_fixes drivers/ide/ide-taskfile.c
> --- linux-2.6.7-bk11/drivers/ide/ide-taskfile.c~ide_tf_pio_out_fixes 2004-06-28 21:15:54.030210376 +0200
> +++ linux-2.6.7-bk11-bzolnier/drivers/ide/ide-taskfile.c 2004-06-28 21:15:54.035209616 +0200
> @@ -409,6 +409,10 @@ ide_startstop_t task_out_intr (ide_drive
> if (!OK_STAT(stat = hwif->INB(IDE_STATUS_REG), DRIVE_READY, drive->bad_wstat)) {
> return DRIVER(drive)->error(drive, "task_out_intr", stat);
> }
> +
> + if (((stat & DRQ_STAT) == 0) ^ !rq->current_nr_sectors)
> + return DRIVER(drive)->error(drive, __FUNCTION__, stat);
> +
Looks pretty close to obfuscated c code contents... Can't you use !=
or kill ! in second clause and use == or something?
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-07-02 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-30 15:24 [PATCH] ide-taskfile.c fixups/cleanups part #2 [1/9] Bartlomiej Zolnierkiewicz
2004-07-02 12:20 ` Pavel Machek [this message]
2004-07-02 16:43 ` Bartlomiej Zolnierkiewicz
2004-07-02 19:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040702122004.GC12889@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.