From: "J. Bruce Fields" <bfields@fieldses.org>
To: Yichen Xie <yxie@cs.stanford.edu>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Neil Brown <neilb@cse.unsw.edu.au>
Subject: Re: [BUGS] [CHECKER] 99 synchronization bugs and a lock summary database
Date: Fri, 2 Jul 2004 13:00:19 -0400 [thread overview]
Message-ID: <20040702170019.GA32756@fieldses.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0407020933300.23611-100000@kaki.stanford.edu>
On Fri, Jul 02, 2004 at 09:39:40AM -0700, Yichen Xie wrote:
> indeed, the code looks different in 2.6.7. definitely not a double unlock
> any more, but it seems the new version exit w/ client_sema unheld at line
> 1616, and w/ the lock held at line 1625. is there a correlation between
> the return value with the lock state? -yichen
Yes. The unlock happens at either nfs4xdr.c:1280 (ENCODE_SEQID_OP_TAIL)
or nfs4xdr.c:2534 (nfsd4_encode_replay()), and in the former case the
unlock is conditional on the value of the oc_stateowner field that's set
before the nfs4_lock_state() in nfsd4_open_confirm().
So while I believe the code as it stands is correct, it's not just your
checker that's going to find this confusing! I'll work on a fix....--b.
next prev parent reply other threads:[~2004-07-02 17:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-02 1:01 [BUGS] [CHECKER] 99 synchronization bugs and a lock summary database Yichen Xie
2004-07-02 4:35 ` Nathan Scott
2004-07-02 7:06 ` Yichen Xie
2004-07-02 7:44 ` Andrew Morton
2004-07-02 16:48 ` Yichen Xie
2004-07-02 20:42 ` Yichen Xie
2004-07-02 21:12 ` Yichen Xie
2004-07-02 22:50 ` J. Bruce Fields
2004-07-02 23:44 ` Yichen Xie
2004-07-02 4:38 ` Andrew Morton
2004-07-02 7:20 ` Yichen Xie
2004-07-02 7:33 ` Andrew Morton
2004-07-02 7:39 ` Martin Diehl
2004-07-02 10:00 ` Matthias Urlichs
2004-07-02 22:32 ` Andrew Morton
2004-07-02 8:15 ` Andrew Morton
2004-07-02 16:53 ` Yichen Xie
2004-07-02 8:19 ` Andrew Morton
2004-07-02 16:39 ` Yichen Xie
2004-07-02 17:00 ` J. Bruce Fields [this message]
2004-07-02 8:47 ` YOSHIFUJI Hideaki / 吉藤英明
-- strict thread matches above, loose matches on Subject: below --
2004-07-02 7:49 Fw: " Andrew Morton
2004-07-02 11:04 ` Herbert Xu
2004-07-02 19:30 ` Andrew Morton
2004-07-02 19:50 ` Stephen Hemminger
2004-07-03 5:42 ` OGAWA Hirofumi
2004-07-03 6:13 ` Herbert Xu
2004-07-03 8:03 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040702170019.GA32756@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=yxie@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.