All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Roland Dreier <roland@topspin.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add some PCI Express constants to pci.h
Date: Fri, 2 Jul 2004 13:57:12 -0700	[thread overview]
Message-ID: <20040702205712.GE29580@kroah.com> (raw)
In-Reply-To: <52r7rwj40o.fsf@topspin.com>

On Wed, Jun 30, 2004 at 11:26:47AM -0700, Roland Dreier wrote:
> This patch adds some PCI Express register constants to <linux/pci.h>
> 
> For my device, setting the Max_Read_Request_Size value in the PCI
> Express device control register makes a huge performance difference.
> I wanted my driver code that does this to be a little more
> self-documenting than:
> 
> 	pci_read_config_word(mdev->pdev, cap + 8, &val);
> 	val = (val & ~(5 << 12)) | (5 << 12);
> 
> I went a little overboard and added all the basic device register
> fields.  If desired I could go even further overboard and add the
> link, slot and root registers as well.
> 
> This patch is based on Matthew Wilcox's patch for pciutils, corrected
> for some PCI Express spec 1.0a changes.
> 
> Signed-off-by: Roland Dreier <roland@topspin.com>

Applied, thanks.

greg k-h

      reply	other threads:[~2004-07-02 21:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-30 18:26 [PATCH] Add some PCI Express constants to pci.h Roland Dreier
2004-07-02 20:57 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040702205712.GE29580@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@topspin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.