From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261875AbUGEU2X (ORCPT ); Mon, 5 Jul 2004 16:28:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261857AbUGEU2X (ORCPT ); Mon, 5 Jul 2004 16:28:23 -0400 Received: from mout0.freenet.de ([194.97.50.131]:50877 "EHLO mout0.freenet.de") by vger.kernel.org with ESMTP id S261875AbUGEU2E convert rfc822-to-8bit (ORCPT ); Mon, 5 Jul 2004 16:28:04 -0400 From: Michael Buesch To: linux kernel mailing list Subject: explanation of apm_do_idle() Date: Mon, 5 Jul 2004 22:27:24 +0200 User-Agent: KMail/1.6.2 MIME-Version: 1.0 Content-Disposition: inline Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Message-Id: <200407052227.29141.mbuesch@freenet.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, What's the purpose of t = jiffies; in apm_do_idle()? Looks very strange and incorrect to me, but I think there's a reason for it. Sorry for stealing your time, but I really don't get behind it. Thank you! static int apm_do_idle(void) { u32 eax; if (apm_bios_call_simple(APM_FUNC_IDLE, 0, 0, &eax)) { static unsigned long t; /* This always fails on some SMP boards running UP kernels. * Only report the failure the first 5 times. */ if (++t < 5) { printk(KERN_DEBUG "apm_do_idle failed (%d)\n", (eax >> 8) & 0xff); t = jiffies; } return -1; } clock_slowed = (apm_info.bios.flags & APM_IDLE_SLOWS_CLOCK) != 0; return clock_slowed; } - -- Regards Michael Buesch [ http://www.tuxsoft.de.vu ] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFA6bmsFGK1OIvVOP4RAj7tAJ9oogV61ZIy6NfEJK4VPRTDPJ0ZFgCbBlAn ahI36YWo83478oVQ9/p1wW4= =umcI -----END PGP SIGNATURE-----