From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jmorris@redhat.com, netdev@oss.sgi.com
Subject: Re: pskb change in dst->output
Date: Wed, 7 Jul 2004 15:01:32 -0700 [thread overview]
Message-ID: <20040707150132.5dc470b6.davem@redhat.com> (raw)
In-Reply-To: <20040707212805.GA29899@gondor.apana.org.au>
On Thu, 8 Jul 2004 07:28:05 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> OK. Can you please tell me which caller of dst_output() passes
> a cloned skb to it?
>
> I need to know this because if this is the case, we need fix the various
> IPsec output functions to copy the skb.
They do already, via skb_cow().
The case James's patch tries to deal with is when multicast
loops back packets to localhost, see ip_mc_output().
Since the SKB is a clone, if we do anything with the checksum
state of the clone, this messes up the hw checksumming state
of the original SKB and we get output packets with corrupt
checksums.
next prev parent reply other threads:[~2004-07-07 22:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-07 13:06 pskb change in dst->output Herbert Xu
2004-07-07 14:58 ` James Morris
2004-07-07 21:28 ` Herbert Xu
2004-07-07 22:01 ` David S. Miller [this message]
2004-07-07 23:12 ` Herbert Xu
2004-07-07 23:33 ` James Morris
2004-07-08 0:04 ` Herbert Xu
2004-07-08 0:17 ` David S. Miller
2004-07-08 0:35 ` Herbert Xu
2004-07-08 1:05 ` James Morris
2004-07-08 1:11 ` Herbert Xu
2004-07-08 1:19 ` James Morris
2004-07-08 3:34 ` James Morris
2004-07-08 4:02 ` Herbert Xu
2004-07-09 8:14 ` Herbert Xu
2004-07-09 14:02 ` James Morris
2004-07-09 19:36 ` David S. Miller
2004-07-09 20:42 ` Herbert Xu
2004-07-09 21:07 ` Herbert Xu
2004-07-09 21:21 ` David S. Miller
2004-07-09 21:43 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040707150132.5dc470b6.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.