From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: mason@suse.com, marcelo.tosatti@cyclades.com,
linux-kernel@vger.kernel.org
Subject: Re: Unnecessary barrier in sync_page()?
Date: Thu, 8 Jul 2004 00:02:58 +0200 [thread overview]
Message-ID: <20040707220258.GV28479@dualathlon.random> (raw)
In-Reply-To: <20040707143015.03379d0f.akpm@osdl.org>
On Wed, Jul 07, 2004 at 02:30:15PM -0700, Andrew Morton wrote:
> And we cannot lock the page because, err, we need to run sync_page() for
> that.
exactly ;)
> But I cannot think of any callers of sync_page() who don't have a ref on
> the inode, so...
I'm thinking, does handle_write_error() holds a ref on the inode? that's
the VM and it finds the page without passing through the inode. I'm
afraid the VM isn't safe calling lock_page, or am I overlooking
something here?
next prev parent reply other threads:[~2004-07-07 22:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-07 17:57 Unnecessary barrier in sync_page()? Marcelo Tosatti
2004-07-07 18:20 ` Andrea Arcangeli
2004-07-07 18:29 ` Andrew Morton
2004-07-07 18:42 ` Andrea Arcangeli
2004-07-07 18:46 ` Andrea Arcangeli
2004-07-07 20:57 ` Chris Mason
2004-07-07 21:06 ` Andrea Arcangeli
2004-07-07 21:15 ` Chris Mason
2004-07-07 21:30 ` Andrew Morton
2004-07-07 21:34 ` Chris Mason
2004-07-07 22:02 ` Andrea Arcangeli [this message]
2004-07-07 22:27 ` Andrew Morton
2004-07-07 18:58 ` Marcelo Tosatti
2004-07-07 19:12 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040707220258.GV28479@dualathlon.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=mason@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.