From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org, mason@suse.com
Subject: Re: writepage fs corruption fixes
Date: Sat, 10 Jul 2004 03:07:38 +0200 [thread overview]
Message-ID: <20040710010738.GX20947@dualathlon.random> (raw)
In-Reply-To: <20040710001600.GT20947@dualathlon.random>
On Sat, Jul 10, 2004 at 02:16:00AM +0200, Andrea Arcangeli wrote:
> I hope this time I'm done with it.
I'm not after more thinking it seems the below is not a bug.
I'm lost since I can't find bugs anymore in this function but I need to
find something.
>
> --- sles/fs/mpage.c.~1~ 2004-07-09 23:48:33.233205496 +0200
> +++ sles/fs/mpage.c 2004-07-10 02:11:59.922789800 +0200
> @@ -460,7 +460,7 @@ mpage_writepage(struct bio *bio, struct
> */
> BUG_ON(!PageUptodate(page));
> block_in_file = page->index << (PAGE_CACHE_SHIFT - blkbits);
> - last_block = (i_size_read(inode) - 1) >> blkbits;
> + last_block = (i_size_read(inode) + (1 << blkbits) - 1) >> blkbits;
> map_bh.b_page = page;
> for (page_block = 0; page_block < blocks_per_page; ) {
>
next prev parent reply other threads:[~2004-07-10 1:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-09 4:01 writepage fs corruption fixes Andrea Arcangeli
2004-07-09 4:06 ` Andrea Arcangeli
2004-07-09 4:19 ` Andrea Arcangeli
2004-07-09 4:29 ` Andrew Morton
2004-07-09 4:42 ` Andrea Arcangeli
2004-07-09 4:56 ` Andrew Morton
2004-07-09 12:43 ` Chris Mason
2004-07-10 0:16 ` Andrea Arcangeli
2004-07-10 1:07 ` Andrea Arcangeli [this message]
2004-07-10 4:30 ` Andrew Morton
2004-07-10 4:59 ` Andrea Arcangeli
2004-07-10 5:56 ` Andrew Morton
2004-07-10 6:11 ` Andrea Arcangeli
2004-07-10 6:13 ` Andrew Morton
2004-07-14 16:14 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040710010738.GX20947@dualathlon.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.