From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S266296AbUGKG46@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S266296AbUGKG46 (ORCPT <rfc822;willy@w.ods.org>);
	Sun, 11 Jul 2004 02:56:58 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266352AbUGKG46
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 11 Jul 2004 02:56:58 -0400
Received: from fw.osdl.org ([65.172.181.6]:15547 "EHLO mail.osdl.org")
	by vger.kernel.org with ESMTP id S266296AbUGKG45 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 11 Jul 2004 02:56:57 -0400
Date: Sat, 10 Jul 2004 23:55:36 -0700
From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@muc.de>
Cc: aoliva@redhat.com, ncunningham@linuxmail.org, linux-kernel@vger.kernel.org
Subject: Re: GCC 3.4 and broken inlining.
Message-Id: <20040710235536.14718bae.akpm@osdl.org>
In-Reply-To: <20040711055352.GB87770@muc.de>
References: <2fFzK-3Zz-23@gated-at.bofh.it>
	<2fG2F-4qK-3@gated-at.bofh.it>
	<2fG2G-4qK-9@gated-at.bofh.it>
	<2fPfF-2Dv-21@gated-at.bofh.it>
	<2fPfF-2Dv-19@gated-at.bofh.it>
	<m34qohrdel.fsf@averell.firstfloor.org>
	<orvfgvo8pr.fsf@livre.redhat.lsd.ic.unicamp.br>
	<20040711055352.GB87770@muc.de>
X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Andi Kleen <ak@muc.de> wrote:
>
> I guess it could be readded if the inlining heuristics were fixed,
>  but even in gcc 3.5 it still looks quite bleak.

It's very simple.  For use in the kernel we don't *want* any inlining
heuristics.  What we want is:

a) If the programmer says "inline", then inline it.

b) If the programmer didn't say "inline" then don't inline it.

Surely it is not hard to add a new option to gcc to provide these semantics?