From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Sun, 11 Jul 2004 10:22:34 +0000 Subject: Re: serious performance regression due to NX patch Message-Id: <20040711102234.GA11534@infradead.org> List-Id: References: <200407100528.i6A5SF8h020094@napali.hpl.hp.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ingo Molnar Cc: davidm@hpl.hp.com, suresh.b.siddha@intel.com, jun.nakajima@intel.com, Andrew Morton , Linus Torvalds , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, Jul 11, 2004 at 05:52:59AM -0400, Ingo Molnar wrote: > > On Sun, 11 Jul 2004, Ingo Molnar wrote: > > > > ok, agreed. I'll check that it still does the right thing on x86. > > > > it doesnt seem to do the right thing for !PT_GNU_STACK applications on > > x86: > > how about the patch below? This way we recognize the fact that x86 didnt > have any executability check previously at the point where we discover > that it's a 'legacy' binary. Please don't add per-architecture ifdefs to generic code. And I'm pretty sure there's quite a few more architectures with the same issue. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266541AbUGKKWr (ORCPT ); Sun, 11 Jul 2004 06:22:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266550AbUGKKWr (ORCPT ); Sun, 11 Jul 2004 06:22:47 -0400 Received: from [213.146.154.40] ([213.146.154.40]:27074 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S266541AbUGKKWp (ORCPT ); Sun, 11 Jul 2004 06:22:45 -0400 Date: Sun, 11 Jul 2004 11:22:34 +0100 From: Christoph Hellwig To: Ingo Molnar Cc: davidm@hpl.hp.com, suresh.b.siddha@intel.com, jun.nakajima@intel.com, Andrew Morton , Linus Torvalds , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: serious performance regression due to NX patch Message-ID: <20040711102234.GA11534@infradead.org> Mail-Followup-To: Christoph Hellwig , Ingo Molnar , davidm@hpl.hp.com, suresh.b.siddha@intel.com, jun.nakajima@intel.com, Andrew Morton , Linus Torvalds , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org References: <200407100528.i6A5SF8h020094@napali.hpl.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 11, 2004 at 05:52:59AM -0400, Ingo Molnar wrote: > > On Sun, 11 Jul 2004, Ingo Molnar wrote: > > > > ok, agreed. I'll check that it still does the right thing on x86. > > > > it doesnt seem to do the right thing for !PT_GNU_STACK applications on > > x86: > > how about the patch below? This way we recognize the fact that x86 didnt > have any executability check previously at the point where we discover > that it's a 'legacy' binary. Please don't add per-architecture ifdefs to generic code. And I'm pretty sure there's quite a few more architectures with the same issue.