All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>,
	aoliva@redhat.com, ncunningham@linuxmail.org,
	linux-kernel@vger.kernel.org
Subject: Re: GCC 3.4 and broken inlining.
Date: Sun, 11 Jul 2004 15:01:18 +0200	[thread overview]
Message-ID: <200407111501.21769.arnd@arndb.de> (raw)
In-Reply-To: <20040711115039.GD4701@fs.tum.de>

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

On Sonntag, 11. Juli 2004 13:50, Adrian Bunk wrote:
> -#if __GNUC_MINOR__ >= 1  && __GNUC_MINOR__ < 4
> +#if __GNUC_MINOR__ >= 1
>  # define inline                __inline__ __attribute__((always_inline))
>  # define __inline__    __inline__ __attribute__((always_inline))
>  # define __inline      __inline__ __attribute__((always_inline))

While we're there, shouldn't this really be the following?

# define inline          inline   __attribute__((always_inline))
# define __inline__    __inline__ __attribute__((always_inline))
# define __inline      __inline   __attribute__((always_inline))

I find it somewhat annoying that the preprocessor expands every "inline"
to "__inline__ __attribute__((always_inline)) __attribute__((always_inline))"
in the current code.

	Arnd <><

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2004-07-11 13:02 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2fFzK-3Zz-23@gated-at.bofh.it>
     [not found] ` <2fG2F-4qK-3@gated-at.bofh.it>
     [not found]   ` <2fG2G-4qK-9@gated-at.bofh.it>
     [not found]     ` <2fPfF-2Dv-21@gated-at.bofh.it>
     [not found]       ` <2fPfF-2Dv-19@gated-at.bofh.it>
2004-07-09  4:51         ` GCC 3.4 and broken inlining Andi Kleen
2004-07-09  4:56           ` Nigel Cunningham
2004-07-09  5:46             ` Andi Kleen
2004-07-09  9:43               ` Michael Buesch
2004-07-09 10:23                 ` Paweł Sikora
2004-07-10 21:33             ` Alexandre Oliva
2004-07-11  5:52               ` Andi Kleen
2004-07-14  3:00                 ` Alexandre Oliva
2004-07-09 18:40           ` Adrian Bunk
2004-07-09 21:54             ` Andi Kleen
2004-07-09 22:17               ` Adrian Bunk
2004-07-10  4:50                 ` Andi Kleen
2004-07-10 21:25           ` Alexandre Oliva
2004-07-11  5:53             ` Andi Kleen
2004-07-11  6:55               ` Andrew Morton
2004-07-11  8:26                 ` Andi Kleen
2004-07-11  8:32                   ` Andrew Morton
2004-07-11  9:08                     ` Andi Kleen
2004-07-11 11:50                     ` Adrian Bunk
2004-07-11 13:01                       ` Arnd Bergmann [this message]
2004-07-13  1:02                         ` [updated 2.6 patch] #define inline as __attribute__((always_inline)) also for gcc >= 3.4 Adrian Bunk
     [not found] <fa.hnj36kg.4no2jk@ifi.uio.no>
     [not found] ` <fa.gktbdsg.1n4em8o@ifi.uio.no>
2004-07-10  3:12   ` GCC 3.4 and broken inlining Robert Hancock
     [not found] <2fVEt-6Vy-11@gated-at.bofh.it>
     [not found] ` <2fVO5-79H-3@gated-at.bofh.it>
     [not found]   ` <2fWqQ-7uv-19@gated-at.bofh.it>
     [not found]     ` <2g0b6-1Cf-23@gated-at.bofh.it>
2004-07-09 10:04       ` Andi Kleen
2004-07-08 11:46 Nigel Cunningham
2004-07-08 12:07 ` Jakub Jelinek
2004-07-08 12:11   ` Nigel Cunningham
     [not found]     ` <200407090036.39323.vda@port.imtp.ilyichevsk.odessa.ua>
2004-07-08 22:00       ` Nigel Cunningham
2004-07-08 22:41         ` Zan Lynx
2004-07-09  6:54           ` Arjan van de Ven
2004-07-10 21:20             ` Alexandre Oliva
2004-07-08 20:52   ` Adrian Bunk
2004-07-08 21:09     ` Arjan van de Ven
2004-07-08 22:08       ` Nigel Cunningham
2004-07-08 22:25         ` Adrian Bunk
2004-07-08 22:37           ` Nigel Cunningham
2004-07-09  6:24         ` Arjan van de Ven
2004-07-10  1:21           ` Adrian Bunk
2004-07-10  2:30             ` William Lee Irwin III
2004-07-13 22:19               ` Timothy Miller
2004-07-10  6:31             ` Arjan van de Ven
2004-07-10 21:17       ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200407111501.21769.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=aoliva@redhat.com \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@linuxmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.