On Mon, 12 Jul 2004 18:55:39 -0700, Randy.Dunlap wrote:
> This is my 'dryrun' script:
> 
> #! /bin/sh
> patch -sp1 --dry-run -i $1 $2 $3 $4 $5 $6 $7 $8 $9

What are all these arguments meant for? Why not $@?

> echo "===== trailing spaces? ====="
> grep -n "^+.* $" $1 | more

How about
grep -n '^+.*[[:space:]]$'
instead? Catches trailing tabs as well. And yes, there are plenty of those
in the kernel.

I notice whitespace problems when I review the code anyway, but script
users should also try and catch these:

  	f();
should really be
	f();

Roger