From: Pete Zaitcev <zaitcev@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: [linux-usb-devel] no set_current_state()
Date: Tue, 13 Jul 2004 19:34:43 +0000 [thread overview]
Message-ID: <20040713123443.5af7dfd7@lembas.zaitcev.lan> (raw)
In-Reply-To: <200407132053.18110.oliver@neukum.org>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On Tue, 13 Jul 2004 20:57:14 +0200
Oliver Neukum <oliver@neukum.org> wrote:
> Am Dienstag, 13. Juli 2004 19:57 schrieb Nishanth Aravamudan:
> > In continuing to replace, where appropriate, code with msleep() calls, I
> > ran across the following file(s) / function(s), which do not invoke
> > set_current_state() before schedule_timeout(), which causes the latter
> > to return immediately:
> >
> > drivers/usb/misc/tiglusb.c::tiglusb_open()
>
> TASK_INTERRUPTIBLE
In this case, Oliver is right. However, do not use TASK_INTERRUPTIBLE
in any path which is called from ->release(). When an application is
killed with ^C and is exiting, schedule() returns immediately if
called so, so the end result would be a fix with no effect.
-- Pete
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-07-13 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 18:53 [Kernel-janitors] Re: [linux-usb-devel] no set_current_state() Oliver Neukum
2004-07-13 18:55 ` Oliver Neukum
2004-07-13 18:57 ` Oliver Neukum
2004-07-13 18:59 ` Oliver Neukum
2004-07-13 19:00 ` Oliver Neukum
2004-07-13 19:00 ` Oliver Neukum
2004-07-13 19:16 ` David Brownell
2004-07-13 19:34 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040713123443.5af7dfd7@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.