All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Hugang <hugang@soulinfo.com>
Cc: linux-kernel@vger.kernel.org, bcollins@debian.org
Subject: Re: [PATCH] fix rmmod sbp2 hang in 2.6.7
Date: Wed, 14 Jul 2004 11:20:38 +0100	[thread overview]
Message-ID: <20040714112038.A14881@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040714172957.52de0f9b@localhost>; from hugang@soulinfo.com on Wed, Jul 14, 2004 at 05:29:57PM +0800

On Wed, Jul 14, 2004 at 05:29:57PM +0800, Hugang wrote:
> On Wed, 14 Jul 2004 10:24:17 +0100
> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> | This down+up prevents drivers from being unloaded until there are no
> | references to their struct device_driver.  By removing this, you open
> | the very real possibility for an oops to occur.
> Yes, I agree with you. When sbp2 is using the module count is not zero, 
> so I can rmmod it, So I think, for sbp2 that's safe, That's true on my
> laptop.

The module count does not cover all cases, especially the case which this
semaphore protects against.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

  reply	other threads:[~2004-07-14 10:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-14  3:48 [PATCH] fix rmmod sbp2 hang in 2.6.7 Hugang
2004-07-14  8:13 ` Hugang
2004-07-14  9:11   ` Hugang
2004-07-14  9:24     ` Russell King
2004-07-14  9:29       ` Hugang
2004-07-14 10:20         ` Russell King [this message]
2004-07-14 11:33       ` Ben Collins
2004-07-17 18:43         ` Tim Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040714112038.A14881@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=bcollins@debian.org \
    --cc=hugang@soulinfo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.