All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: mikpe@csd.uu.se, B.Zolnierkiewicz@elka.pw.edu.pl,
	dgilbert@interlog.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix
Date: Wed, 14 Jul 2004 14:35:08 -0700	[thread overview]
Message-ID: <20040714143508.3dc25d58.akpm@osdl.org> (raw)
In-Reply-To: <40F57D14.9030005@pobox.com>

Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Or you could just call it "gcc is dumb" rather than a compiler bug.

Yeah, but doing:

	static inline foo(void);

	bar()
	{
		...
		foo();
	}

	static inline foo(void)
	{
		...
	}

is pretty dumb too.  I don't see any harm if this compiler feature/problem
pushes us to fix the above in the obvious way.

Plus if we do, the inlining attempt actually succeed, on all compiler
versions.


  parent reply	other threads:[~2004-07-14 22:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-14 17:51 [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix Mikael Pettersson
2004-07-14 18:36 ` Jeff Garzik
2004-07-14 19:05   ` Adrian Bunk
2004-07-14 21:35   ` Andrew Morton [this message]
2004-07-14 23:39     ` Jeff Garzik
2004-07-14 22:39       ` Andrew Morton
2004-07-15  0:19       ` Matthew Wilcox
2004-07-15  5:56     ` Jens Axboe
2004-07-15  6:12       ` William Lee Irwin III
2004-07-15 15:42     ` Douglas Gilbert
  -- strict thread matches above, loose matches on Subject: below --
2004-07-15  9:46 Mikael Pettersson
2004-07-15 13:09 ` Jeff Garzik
2004-07-15 15:58   ` Matthew Wilcox
2004-07-15 14:36 ` William Lee Irwin III
2004-07-14 12:16 Mikael Pettersson
2004-07-14 15:52 ` Jeff Garzik
2004-07-14 16:42   ` Adrian Bunk
2004-07-14 16:44     ` Jeff Garzik
2004-07-14 16:54       ` Adrian Bunk
2004-07-14 17:31         ` Bartlomiej Zolnierkiewicz
2004-07-14 18:33           ` Adrian Bunk
2004-07-14 18:44             ` Jeff Garzik
2004-07-14 19:06             ` Douglas Gilbert
2004-07-26 22:09             ` Andrew Morton
2004-07-14 18:34           ` Jeff Garzik
2004-07-14 18:31         ` Jeff Garzik
2004-07-14 15:57 ` Bartlomiej Zolnierkiewicz
2004-07-14 15:59   ` Jeff Garzik
2004-07-26 21:53 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040714143508.3dc25d58.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=dgilbert@interlog.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mikpe@csd.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.