From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PARCH] driver core: add driver_find to find a driver by name
Date: Thu, 15 Jul 2004 23:41:14 -0500 [thread overview]
Message-ID: <200407152341.14189.dtor_core@ameritech.net> (raw)
In-Reply-To: <20040715123018.GA17486@logos.cnet>
On Thursday 15 July 2004 07:30 am, Marcelo Tosatti wrote:
> On Wed, Jul 14, 2004 at 04:02:46PM -0700, Greg KH wrote:
> > On Sun, Jun 27, 2004 at 09:26:03PM -0500, Dmitry Torokhov wrote:
> > > Hi,
> > >
> > > Here is a patch that adds driver_find() that allows to search for a driver
> > > on a bus by it's name. The function is similar to device_find already present
> > > in the tree. I need it for my serio sysfs patches where user can re-bind
> > > serio port to an alternate driver by echoing driver's name to serio port's
> > > driver attribute.
> >
> > Applied, thanks.
>
> Dmitry,
>
> I remember you fixed kset_find_obj() to get a reference count on the kobject.
>
> driver_find()/device_find() use that, maybe it would be nice to add a comment
> on top of those saying the caller is responsible for putting the refcount
> on the kobject?
>
> Last time I looked at your patches there was no such comment on driver_find/device_find,
> only kset_find_obj().
>
> Just nitpicking.
>
Hi Marcelo,
I tried to document driver_find, device_find and find_bus, please check out
the version that Greg has committed. If comments still somewhat unclear I
will try redoing them.
--
Dmitry
next prev parent reply other threads:[~2004-07-16 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-28 2:26 [PARCH] driver core: add driver_find to find a driver by name Dmitry Torokhov
2004-06-28 8:41 ` Christoph Hellwig
2004-07-14 23:02 ` Greg KH
2004-07-15 12:30 ` Marcelo Tosatti
2004-07-16 4:41 ` Dmitry Torokhov [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-28 13:37 Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200407152341.14189.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.