From: Andi Kleen <ak@muc.de>
To: Martin Diehl <lists@mdiehl.de>
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@oss.sgi.com, irda-users@lists.sourceforge.net,
jt@hpl.hp.com, the_nihilant@autistici.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Drop ISA dependencies from IRDA drivers
Date: 16 Jul 2004 07:45:50 +0200
Date: Fri, 16 Jul 2004 07:45:50 +0200 [thread overview]
Message-ID: <20040716054550.GA21819@muc.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0407160027410.14037-100000@notebook.home.mdiehl.de>
On Fri, Jul 16, 2004 at 12:32:44AM +0200, Martin Diehl wrote:
> On 15 Jul 2004, Andi Kleen wrote:
>
> > Remove wrong ISA dependencies for IRDA drivers.
> >
> >
> > diff -u linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig
> > --- linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o 2004-07-12 06:09:05.000000000 +0200
> > +++ linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig 2004-07-15 18:33:48.000000000 +0200
> > @@ -310,7 +310,7 @@
> >
> > config NSC_FIR
> > tristate "NSC PC87108/PC87338"
> > - depends on IRDA && ISA
> > + depends on IRDA
>
>
> Admittedly I haven't tried either, but I'm pretty sure this patch will
> break building those drivers because they are calling irda_setup_dma -
> which is CONFIG_ISA. Maybe this can be dropped but I don't see what's
> wrong with !64BIT instead.
Hmm, good point.
!64BIT is not needed - apparently they are 64bit clean.
The reason I want to drop the CONFIG_ISA depency is that they *should*
be built on x86-64 too.
-Andi
next prev parent reply other threads:[~2004-07-16 5:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m34qo96x8m.fsf@averell.firstfloor.org>
2004-07-15 16:48 ` [PATCH] Drop ISA dependencies from IRDA drivers Jeff Garzik
2004-07-15 20:50 ` Andi Kleen
2004-07-15 21:00 ` Jeff Garzik
2004-07-15 21:55 ` Andi Kleen
2004-07-15 22:32 ` Martin Diehl
2004-07-15 22:42 ` Jean Tourrilhes
2004-07-15 22:57 ` Martin Diehl
2004-07-16 5:45 ` Andi Kleen [this message]
2004-07-16 6:19 ` Martin Diehl
2004-07-16 6:19 ` Andi Kleen
2004-07-16 6:33 ` Martin Diehl
2004-07-15 22:35 ` Jean Tourrilhes
2004-07-16 5:36 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040716054550.GA21819@muc.de \
--to=ak@muc.de \
--cc=irda-users@lists.sourceforge.net \
--cc=jgarzik@pobox.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@mdiehl.de \
--cc=netdev@oss.sgi.com \
--cc=the_nihilant@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.