From: Andreas Dilger <adilger@clusterfs.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] Re: ext3: bump mount count on journal replay
Date: Fri, 16 Jul 2004 14:41:35 -0600 [thread overview]
Message-ID: <20040716204135.GG6770@schnapps.adilger.int> (raw)
In-Reply-To: <20040714203258.GC25802@elf.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
On Jul 14, 2004 22:32 +0200, Pavel Machek wrote:
> > AFAICS, this just means that if you have an ext3 filesystem
> > (i.e. has_journal) that you will fsck 5x as often, not so great. You
> > should instead check for INCOMPAT_RECOVER instead of HAS_JOURNAL.
>
> Oops, you are right. Updated patch is attached.
No patch was attached.
> > Instead, you could change this to only increment the mount count after
> > a clean unmount 20% of the time (randomly). Since most people bitch
> > about the full fsck anyways this is probably the better choice than
> > increasing the frequency of checks and forcing the users to change the
> > check interval to get the old behaviour.
>
> Nice hack.... would that be acceptable?
It's OK by me. I don't think you'll get complaints from users if it is
checked less often (there is still the time-based check).
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-07-16 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 13:15 ext3: bump mount count on journal replay Pavel Machek
2004-07-14 19:55 ` Theodore Ts'o
2004-07-14 20:30 ` Pavel Machek
2004-07-14 20:05 ` Andreas Dilger
2004-07-14 20:32 ` Pavel Machek
2004-07-16 20:41 ` Andreas Dilger [this message]
2004-07-16 21:06 ` [Ext2-devel] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040716204135.GG6770@schnapps.adilger.int \
--to=adilger@clusterfs.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.