From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: sis-agp: replace schedule_timeout() with
Date: Tue, 20 Jul 2004 22:39:19 +0000 [thread overview]
Message-ID: <20040720223919.GA2447@masina> (raw)
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On 20/07/04 21:01 +0000, Nishanth Aravamudan wrote:
...
> --- linux-vanilla/drivers/char/agp/sis-agp.c 2004-06-16 05:18:56.000000000 +0000
...
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout (1+(HZ*10)/1000);
> + msleep(HZ); /* sleep 1s */
Umm... what?
I mean... HZ jiffies is one second, but HZ miliseconds is not necessary 1 s.
And that delay looks wierd, what was the point of HZ*10/1000 in the first
place? Why not HZ/100?
Anyway, IMO msleep(10) seems right.
Domen
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-07-20 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-20 22:39 Domen Puncer [this message]
2004-07-20 23:15 ` [Kernel-janitors] Re: sis-agp: replace schedule_timeout() with Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040720223919.GA2447@masina \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.